From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: list-snapshots improvements
Date: Wed, 3 Jul 2024 15:46:56 +0200 (CEST) [thread overview]
Message-ID: <1304461813.3688.1720014416614@webmail.proxmox.com> (raw)
In-Reply-To: <20240703131632.307752-1-g.goller@proxmox.com>
Hi, some initial high level comments, did not test this just yet.
You touch several completely unrelated thing in this patch. I feel that this should be split into at least 3-4 patches:
- fixing the typo
- removing the unsafe block (although this feels like Wolfgang did this on purpose to make a caller aware of possible consequences, see commit message for a577d7d8).
- avoid double retrial of protected flag, (can we also assure that this is not done on purpose, to avoid possible races?)
- refactor of `full_path`
Also, can you see a noticeable difference in listing time for groups with a larger number of backups?
Please give some ballpark figures if so.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-07-03 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 13:16 Gabriel Goller
2024-07-03 13:46 ` Christian Ebner [this message]
2024-07-03 13:55 ` Gabriel Goller
2024-07-03 14:00 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304461813.3688.1720014416614@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.