all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
	Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] tape: fix 'eject-before-unload' api type
Date: Thu, 14 Dec 2023 09:18:24 +0100 (CET)	[thread overview]
Message-ID: <1297224291.1791.1702541904341@webmail.proxmox.com> (raw)
In-Reply-To: <fc01e7b4-9f4a-4826-8707-f1db885aa527@proxmox.com>

> mhmm i modeled it after the 'tuning' options of the datastore.

Which is also clumsy and not really required... I would have used normal options instead...

> maybe it was named badly, and the 'options' should be replaced by 
> 'quirks' (as in, changer quirks that only some people need, like
> the datastore tuning options)
> 
> but if you both want a more straight forward option directly in
> the changer config, then it's also fine with me (i just

> did not want to pollute the changer config with rather
> specific quirk workarounds, and I doubt this is
> the last of them, even though we don't see such things often)

The changer config only has a few option, so we are far away from
a polluted config.

> just tell me if i should rename it to something else (like quirks)
> or if i should put it directly in the changer config, and i'll send
> the patches for it + docs update

Yes, please use normal options unless there is a real requirement to
use a property string.




  reply	other threads:[~2023-12-14  8:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 10:11 Dominik Csapak
2023-12-14  7:46 ` Thomas Lamprecht
2023-12-14  7:52   ` Dominik Csapak
2023-12-14  8:18     ` Dietmar Maurer [this message]
2023-12-14  8:32     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297224291.1791.1702541904341@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal