all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Timothy Nicholson <t.nicholson@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] fix #5302: ui: vm cpu affinity displayed in hardware overview
Date: Mon, 14 Oct 2024 14:38:18 +0200	[thread overview]
Message-ID: <12262a12-03cc-4b08-9be7-9f6ddf715ff1@proxmox.com> (raw)
In-Reply-To: <20241014122603.126568-1-t.nicholson@proxmox.com>

Hi,

Looks mostly good to me, aside from the indentation (as mentioned off-list)
so please send a v2 with the indentation fixed,

thanks

On 10/14/24 14:26, Timothy Nicholson wrote:
> Signed-off-by: Timothy Nicholson <t.nicholson@proxmox.com>
> ---
>   www/manager6/qemu/HardwareView.js | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
> index 86d5f4cf..b607265a 100644
> --- a/www/manager6/qemu/HardwareView.js
> +++ b/www/manager6/qemu/HardwareView.js
> @@ -103,7 +103,7 @@ Ext.define('PVE.qemu.HardwareView', {
>   		tdCls: 'pve-itype-icon-cpu',
>   		group: 3,
>   		defaultValue: '1',
> -		multiKey: ['sockets', 'cpu', 'cores', 'numa', 'vcpus', 'cpulimit', 'cpuunits'],
> +		multiKey: ['sockets', 'cpu', 'cores', 'numa', 'vcpus', 'cpulimit', 'cpuunits', 'affinity'],
>   		renderer: function(value, metaData, record, rowIndex, colIndex, store, pending) {
>   		    var sockets = me.getObjectValue('sockets', 1, pending);
>   		    var model = me.getObjectValue('cpu', undefined, pending);
> @@ -112,6 +112,7 @@ Ext.define('PVE.qemu.HardwareView', {
>   		    var vcpus = me.getObjectValue('vcpus', undefined, pending);
>   		    var cpulimit = me.getObjectValue('cpulimit', undefined, pending);
>   		    var cpuunits = me.getObjectValue('cpuunits', undefined, pending);
> +                    var cpuaffinity = me.getObjectValue('affinity', undefined, pending);
>   
>   		    let res = Ext.String.format(
>   		        '{0} ({1} sockets, {2} cores)', sockets * cores, sockets, cores);
> @@ -131,7 +132,10 @@ Ext.define('PVE.qemu.HardwareView', {
>   		    if (cpuunits) {
>   			res += ' [cpuunits=' + cpuunits +']';
>   		    }
> -
> +                    if (cpuaffinity) {
> +                        res += ' [cpuaffinity=' + cpuaffinity + ']';
> +                    }
> +
>   		    return res;
>   		},
>   	    },
> @@ -214,6 +218,9 @@ Ext.define('PVE.qemu.HardwareView', {
>   	    ostype: {
>   		visible: false,
>   	    },
> +            affinity: {
> +                visible: false,
> +            },
>   	};
>   
>   	PVE.Utils.forEachBus(undefined, function(type, id) {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-10-14 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14 12:26 Timothy Nicholson
2024-10-14 12:38 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12262a12-03cc-4b08-9be7-9f6ddf715ff1@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.nicholson@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal