From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] fix #3610: properly build ZFS detail tree
Date: Fri, 10 Sep 2021 10:05:24 +0200 [thread overview]
Message-ID: <121a3956-50cd-38ad-1f5e-3b30a1418d73@proxmox.com> (raw)
In-Reply-To: <fdef11c3-d22a-9869-bbb8-dafc825cdb89@proxmox.com>
On 10.09.21 10:03, Fabian Ebner wrote:
> Am 09.09.21 um 18:24 schrieb Thomas Lamprecht:
>> hmm, I get the idea and can see how one could assert that this is more correct,
>> but as it is presented it'd be a bit more confusing too, IMO, as it does not
>> matches the zpool status CLI output anymore.
>>
>> I.e., the following (real):
>>> NAME STATE READ WRITE CKSUM
>>> zpt ONLINE 0 0 0
>>> mirror-0 ONLINE 0 0 0
>>> scsi-0QEMU_QEMU_HARDDISK_drive-scsi3 ONLINE 0 0 0
>>> scsi-0QEMU_QEMU_HARDDISK_drive-scsi4 ONLINE 0 0 0
>>> logs
>>> scsi-0QEMU_QEMU_HARDDISK_drive-scsi5 ONLINE 0 0 0
>>
>>
>> Is suggested to be (adapted):
>>> NAME STATE READ WRITE CKSUM
>>> zpt ONLINE
>>> zpt ONLINE 0 0 0
>>> mirror-0 ONLINE 0 0 0
>>> scsi-0QEMU_QEMU_HARDDISK_drive-scsi3 ONLINE 0 0 0
>>> scsi-0QEMU_QEMU_HARDDISK_drive-scsi4 ONLINE 0 0 0
>>> logs
>>> scsi-0QEMU_QEMU_HARDDISK_drive-scsi5 ONLINE 0 0 0
>>
>
> Is 'logs' aligned with the outer 'zpt' or the inner 'zpt'? It's intended to be the inner one, but in the mail it looks like the outer one to me.
>
inner, so that's OK and will keep that way if we drop the root node.
>>
>> How about hiding the root in the devices tree and add a line to the
>> KV grid above instead? E.g., something that would then render:
>>
>> Pool <ID> (<STATUS>)
>>
>> That can be a GUI change only, did not really checked implementation details, but
>> I'd like to clear that up before applying this patch.
>>
>
> I suppose that should be done for PBS too then? And PVE should switch to using the ZFSDetail window from widget-toolkit?
yes to both (ideally).
prev parent reply other threads:[~2021-09-10 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 9:30 Fabian Ebner
2021-09-09 16:24 ` Thomas Lamprecht
2021-09-10 8:03 ` Fabian Ebner
2021-09-10 8:05 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=121a3956-50cd-38ad-1f5e-3b30a1418d73@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.