From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Markus Frank <m.frank@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui v5 10/10] add panel for realms to User Management
Date: Fri, 21 Feb 2025 13:45:55 +0100 (CET) [thread overview]
Message-ID: <1206226125.10150.1740141955656@webmail.proxmox.com> (raw)
In-Reply-To: <20250218161905.17224-11-m.frank@proxmox.com>
> Markus Frank <m.frank@proxmox.com> hat am 18.02.2025 17:19 CET geschrieben:
>
>
> Make the realm configuration available in PMG and disable LDAP/AD
> realms for now and use the name oidc instead of openid.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> js/UserManagement.js | 6 ++++++
> js/Utils.js | 23 +++++++++++++++++++++++
> 2 files changed, 29 insertions(+)
>
> diff --git a/js/UserManagement.js b/js/UserManagement.js
> index 65fabbf..54493b1 100644
> --- a/js/UserManagement.js
> +++ b/js/UserManagement.js
> @@ -34,5 +34,11 @@ Ext.define('PMG.UserManagement', {
> itemId: 'pop',
> iconCls: 'fa fa-reply-all',
> },
> + {
> + xtype: 'pmxAuthView',
> + title: gettext('Realms'),
> + itemId: 'domains',
> + iconCls: 'fa fa-address-book-o',
> + },
> ],
> });
> diff --git a/js/Utils.js b/js/Utils.js
> index 9b5f054..055b938 100644
> --- a/js/Utils.js
> +++ b/js/Utils.js
> @@ -851,6 +851,29 @@ Ext.define('PMG.Utils', {
> constructor: function() {
> var me = this;
>
> + // use oidc instead of openid
> + Proxmox.Schema.authDomains.oidc = Proxmox.Schema.authDomains.openid;
> + Proxmox.Schema.authDomains.oidc.useTypeInUrl = false;
> + delete Proxmox.Schema.authDomains.openid;
unless we want to rename it to oidc everywhere, this makes me think that it's not a good idea to deviate from the existing naming scheme in PMG?
> +
> + // Disable LDAP/AD as a realm until LDAP/AD login is implemented
> + Proxmox.Schema.authDomains.ldap.add = false;
> + Proxmox.Schema.authDomains.ad.add = false;
> +
> + Proxmox.Schema.authDomains.pmg = {
> + add: false,
> + edit: false,
> + pwchange: false,
> + sync: false,
> + };
> +
> + Proxmox.Schema.authDomains.pam = {
> + add: false,
> + edit: false,
> + pwchange: false,
> + sync: false,
> + };
> +
> // do whatever you want here
> Proxmox.Utils.override_task_descriptions({
> applycustomscores: ['', gettext('Apply custom SpamAssassin scores')],
> --
> 2.39.5
>
>
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-02-21 12:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 16:18 [pmg-devel] [PATCH pve-common/perl-rs/pmg-api/widget-toolkit/pmg-gui v5 0/10] fix #3892: OpenID Connect Markus Frank
2025-02-18 16:18 ` [pmg-devel] [PATCH pve-common v5 1/10] add Schema package with auth module that contains realm sync options Markus Frank
2025-02-19 18:18 ` Stoiko Ivanov
2025-02-21 12:22 ` Fabian Grünbichler
2025-02-18 16:18 ` [pmg-devel] [PATCH proxmox-perl-rs v5 2/10] move openid code from pve-rs to common Markus Frank
2025-02-21 12:25 ` Fabian Grünbichler
2025-02-18 16:18 ` [pmg-devel] [PATCH proxmox-perl-rs v5 3/10] remove empty PMG::RS::OpenId package to avoid confusion Markus Frank
2025-02-18 16:18 ` [pmg-devel] [PATCH pmg-api v5 4/10] config: add plugin system for realms Markus Frank
2025-02-21 12:35 ` Fabian Grünbichler
2025-02-18 16:19 ` [pmg-devel] [PATCH pmg-api v5 5/10] config: add oidc type realm Markus Frank
2025-02-21 12:38 ` Fabian Grünbichler
2025-02-18 16:19 ` [pmg-devel] [PATCH pmg-api v5 6/10] api: add/update/remove realms like in PVE Markus Frank
2025-02-21 12:41 ` Fabian Grünbichler
2025-02-21 13:44 ` Markus Frank
2025-02-21 13:52 ` Fabian Grünbichler
2025-02-21 14:38 ` Stoiko Ivanov
2025-02-21 16:45 ` Thomas Lamprecht
2025-02-18 16:19 ` [pmg-devel] [PATCH pmg-api v5 7/10] api: oidc login similar to PVE Markus Frank
2025-02-19 18:31 ` Stoiko Ivanov
2025-02-21 12:44 ` Fabian Grünbichler
2025-02-18 16:19 ` [pmg-devel] [PATCH widget-toolkit v5 8/10] fix: window: AuthEditBase: rename variable 'realm' to 'type' Markus Frank
2025-02-21 12:45 ` Fabian Grünbichler
2025-02-18 16:19 ` [pmg-devel] [PATCH pmg-gui v5 09/10] login: add option to login with OIDC realm Markus Frank
2025-02-18 16:19 ` [pmg-devel] [PATCH pmg-gui v5 10/10] add panel for realms to User Management Markus Frank
2025-02-21 9:22 ` Christoph Heiss
2025-02-21 12:45 ` Fabian Grünbichler [this message]
2025-02-19 18:39 ` [pmg-devel] [PATCH pve-common/perl-rs/pmg-api/widget-toolkit/pmg-gui v5 0/10] fix #3892: OpenID Connect Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206226125.10150.1740141955656@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal