all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH SERIES common/firewall/qemu-server/container 0/1] Cleanup use of PVE::Firewall
@ 2022-06-29  9:08 Alexandre Derumier
  2022-06-29  9:08 ` [pve-devel] [PATCH qemu-server 1/2] api2: use firewall helpers Alexandre Derumier
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Alexandre Derumier @ 2022-06-29  9:08 UTC (permalink / raw)
  To: pve-devel

Hi,

I was doing some profiling of qm && pct command,
and I have found around 100ms cpu time just for the
use of PVE::Firewall in qemu-server && pve-container
for 2 small helpers. (clone_vmfw_conf && remove_vmfw_conf)

as PVE::Firewall require QemuServer && LXC,
we are loading full lxc in qm too.

Also, LXC have some include of PVE::Firewall
in different packages, not used,
but it was magically including QemuServer,
which including the json schema "pve-targetstorage",
used by lxc too.

I have moved this schema to main jsonschema in pve-common


Alexandre Derumier (1):
  schema: add pve-targetstorage (moved from qemu-server)

 src/PVE/JSONSchema.pm | 7 +++++++
 1 file changed, 7 insertions(+)

-- 

Alexandre Derumier (1):
  move clone_vmfw_conf && remove_vmfw_conf to a Helpers

 src/PVE/Firewall.pm         | 25 ----------------------
 src/PVE/Firewall/Helpers.pm | 41 +++++++++++++++++++++++++++++++++++++
 src/PVE/Firewall/Makefile   | 12 +++++++++++
 src/PVE/Makefile            |  2 ++
 4 files changed, 55 insertions(+), 25 deletions(-)
 create mode 100644 src/PVE/Firewall/Helpers.pm
 create mode 100644 src/PVE/Firewall/Makefile

-- 

Alexandre Derumier (2):
  api2: use firewall helpers
  qemu-server: remove json schema pve-targetstorage (moved to
    pve-common)

 PVE/API2/Qemu.pm  | 8 ++++----
 PVE/QemuServer.pm | 7 -------
 2 files changed, 4 insertions(+), 11 deletions(-)

-- 

Alexandre Derumier (2):
  remove unused use PVE::Firewall
  api2 : use firewall helpers

 src/PVE/API2/LXC.pm          | 10 +++++-----
 src/PVE/API2/LXC/Config.pm   |  1 -
 src/PVE/API2/LXC/Snapshot.pm |  1 -
 src/PVE/API2/LXC/Status.pm   |  1 -
 4 files changed, 5 insertions(+), 8 deletions(-)

-- 
2.30.2




^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-11-16 17:09 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29  9:08 [pve-devel] [PATCH SERIES common/firewall/qemu-server/container 0/1] Cleanup use of PVE::Firewall Alexandre Derumier
2022-06-29  9:08 ` [pve-devel] [PATCH qemu-server 1/2] api2: use firewall helpers Alexandre Derumier
2022-06-29  9:08 ` [pve-devel] [PATCH pve-firewall 1/1] move clone_vmfw_conf && remove_vmfw_conf to a Helpers Alexandre Derumier
2022-11-16 17:09   ` [pve-devel] applied: " Thomas Lamprecht
2022-06-29  9:08 ` [pve-devel] [PATCH pve-container 1/2] remove unused use PVE::Firewall Alexandre Derumier
2022-06-29  9:08 ` [pve-devel] [PATCH pve-common 1/1] schema: add pve-targetstorage (moved from qemu-server) Alexandre Derumier
2022-06-29  9:34   ` Thomas Lamprecht
2022-06-29  9:46     ` Fabian Ebner
2022-06-29  9:48       ` Thomas Lamprecht
2022-06-30  7:30     ` DERUMIER, Alexandre
2022-06-30  7:51       ` Thomas Lamprecht
2022-06-29  9:08 ` [pve-devel] [PATCH pve-container 2/2] api2 : use firewall helpers Alexandre Derumier
2022-06-29  9:08 ` [pve-devel] [PATCH qemu-server 2/2] qemu-server: remove json schema pve-targetstorage (moved to pve-common) Alexandre Derumier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal