all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] superseded: [PATCH pve-common 1/1] fix #7153: iproute2: consider bonds as physical bridge ports
Date: Tue, 16 Dec 2025 17:06:22 +0100	[thread overview]
Message-ID: <11ae7393-5827-48ca-a79d-30444ad1422c@proxmox.com> (raw)
In-Reply-To: <20251216094329.36089-1-s.hanreich@proxmox.com>

https://lore.proxmox.com/pve-devel/20251216160513.360391-1-s.hanreich@proxmox.com/T/#u

On 12/16/25 10:43 AM, Stefan Hanreich wrote:
> The new check did not consider bonds, since ip_link_is_physical only
> returns true for physical interfaces - but not bonds. Add a new
> function to check for bonds explicitly and use it when checking for
> bridge ports in activate_bridge_vlan.
> 
> Fixes: 057f62f73
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  src/PVE/IPRoute2.pm | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/IPRoute2.pm b/src/PVE/IPRoute2.pm
> index 5208d93..69c8758 100644
> --- a/src/PVE/IPRoute2.pm
> +++ b/src/PVE/IPRoute2.pm
> @@ -32,6 +32,14 @@ sub ip_link_is_physical($ip_link) {
>          && (!defined($ip_link->{linkinfo}) || !defined($ip_link->{linkinfo}->{info_kind}));
>  }
>  
> +sub ip_link_is_bond($ip_link) {
> +    return
> +        $ip_link->{link_type} eq 'ether'
> +        && defined($ip_link->{linkinfo})
> +        && defined($ip_link->{linkinfo}->{info_kind})
> +        && $ip_link->{linkinfo}->{info_kind} eq 'bond';
> +}
> +
>  sub ip_link_is_bridge($ip_link) {
>      return
>          defined($ip_link->{linkinfo})
> @@ -67,7 +75,8 @@ sub get_physical_bridge_ports($bridge, $ip_links = undef) {
>      }
>  
>      return grep {
> -        ip_link_is_physical($ip_links->{$_}) && $ip_links->{$_}->{master} eq $bridge
> +        (ip_link_is_physical($ip_links->{$_}) || ip_link_is_bond($ip_links->{$_}))
> +            && $ip_links->{$_}->{master} eq $bridge
>      } keys $ip_links->%*;
>  }
>  



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-12-16 16:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16  9:43 [pve-devel] " Stefan Hanreich
2025-12-16 16:06 ` Stefan Hanreich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11ae7393-5827-48ca-a79d-30444ad1422c@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal