From: Dietmar Maurer <dietmar@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [RFC proxmox-backup] PruneJobConfig: make "schedule" optional
Date: Thu, 16 Nov 2023 15:07:25 +0100 (CET) [thread overview]
Message-ID: <1179637567.3988.1700143645633@webmail.proxmox.com> (raw)
In-Reply-To: <7bdef13f-c705-456c-929c-d87946a13675@proxmox.com>
> In other words, sync and verify jobs should gain the disable flag for
> feature parity, and to provide a slightly more obvious way to (temporarily)
> disable a job without loss of (schedule) information.
>
> > Also, update_to_prune_jobs_config() looks wrong now because it remove jobs
> > without a schedule. Was this really indendet?
>
> Without looking to closely into it: That seems indeed rather odd and
> is likely a bug. I did not check your change to closely (sorry, a bit
> overloaded with PVE stuff currently) but did you fix that here too?
Ok, I guess I will then just remove the "optional" flag from the API macro.
prev parent reply other threads:[~2023-11-16 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 13:19 Dietmar Maurer
2023-11-16 13:58 ` Thomas Lamprecht
2023-11-16 14:07 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179637567.3988.1700143645633@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal