From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>,
Timothy Nicholson <t.nicholson@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2] fix #5787: ui: add util function for guest confirmation dialog
Date: Wed, 30 Oct 2024 09:30:13 +0100 [thread overview]
Message-ID: <1140b826-9f84-4e8e-9eb6-757791c8cdf9@proxmox.com> (raw)
In-Reply-To: <vzhmrsve4erbviubcvmdro3pz5gopgmh5p55gwvojfwz6qsrvm@nesqfy75vupl>
Am 29/10/2024 um 13:22 schrieb Christoph Heiss:
> The patch title implies that it only adds a utility function, but the
> patch itself also includes usage for it. Something like
>
> "fix #5787: ui: include guest name in confirmation dialog"
>
> or similar would probably be a better fit.
Yes, that's basically what I suggested in my v1 review:
> fix #5787: ui: display guest name in confirm dialogs
-- https://lore.proxmox.com/pve-devel/87323348-4002-463b-9d6f-48db6eac6d8b@proxmox.com/
Please take advice seriously, it does not need to be followed 1:1, and
sometimes might have been even wrong, but in such a case one should comment
on why that was the case, either in the commit message if it's for a code or
design related or in the change section of a patch for meta ones like here.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-10-30 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 10:39 Timothy Nicholson
2024-10-29 12:22 ` Christoph Heiss
2024-10-29 12:53 ` Shannon Sterz
2024-10-30 8:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140b826-9f84-4e8e-9eb6-757791c8cdf9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.nicholson@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.