From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] node: status: declutter kernel-version
Date: Thu, 23 Nov 2023 17:15:49 +0100 (CET) [thread overview]
Message-ID: <1138109161.1109.1700756149397@webmail.proxmox.com> (raw)
In-Reply-To: <20231123130935.207013-3-g.goller@proxmox.com>
> + let kversion = KernelVersionInformation {
> + sysname: uname.sysname().to_os_string().into_string().unwrap(),
> + release: uname.release().to_os_string().into_string().unwrap(),
> + version: uname.version().to_os_string().into_string().unwrap(),
> + machine: uname.machine().to_os_string().into_string().unwrap(),
> + };
Is it really safe to use unwrap here? If so, I normally add a short
comment to the code to explain why.
next prev parent reply other threads:[~2023-11-23 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 13:09 [pbs-devel] [PATCH proxmox-backup 0/2] Add bootmode, improve kernel version Gabriel Goller
2023-11-23 13:09 ` [pbs-devel] [PATCH proxmox-backup 1/2] node: status: added bootmode Gabriel Goller
2023-11-23 16:32 ` Thomas Lamprecht
2023-11-24 9:04 ` Gabriel Goller
2023-11-24 9:11 ` Thomas Lamprecht
2023-11-23 13:09 ` [pbs-devel] [PATCH proxmox-backup 2/2] node: status: declutter kernel-version Gabriel Goller
2023-11-23 16:15 ` Dietmar Maurer [this message]
2023-11-23 16:29 ` Thomas Lamprecht
2023-11-23 16:35 ` Thomas Lamprecht
2023-11-24 9:13 ` Gabriel Goller
2023-11-23 16:28 ` Thomas Lamprecht
2023-11-24 12:02 ` [pbs-devel] [PATCH proxmox-backup 0/2] Add bootmode, improve kernel version Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138109161.1109.1700756149397@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.