From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Jing Luo <jing@jing.rocks>
Subject: Re: [pve-devel] [PATCH pve-manager] d/control: change binary package architecture from `any` to `all`
Date: Fri, 13 Sep 2024 12:09:19 +0200 (CEST) [thread overview]
Message-ID: <1134670684.29789.1726222159650@webmail.proxmox.com> (raw)
In-Reply-To: <mailman.234.1726153631.414.pve-devel@lists.proxmox.com>
> Jing Luo via pve-devel <pve-devel@lists.proxmox.com> hat am 12.09.2024 16:25 CEST geschrieben:
> There is no architecture dependent binary files in the final deb
> package. There is no shared libs either (says debhelper), so let's remove
> that too.
>
> Signed-off-by: Jing Luo <jing@jing.rocks>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
not applying directly in case I missed some spot where this is hard-coded that requires adaptations, but it seems sound to me.
> ---
> debian/control | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/debian/control b/debian/control
> index d844cc15..a3cb632f 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -34,7 +34,7 @@ Maintainer: Proxmox Support Team <support@proxmox.com>
> Package: pve-manager
> Section: admin
> Priority: optional
> -Architecture: any
> +Architecture: all
> Depends: apt (>= 1.5~),
> ca-certificates,
> cstream,
> @@ -97,7 +97,6 @@ Depends: apt (>= 1.5~),
> zstd,
> ${misc:Depends},
> ${perl:Depends},
> - ${shlibs:Depends},
> Recommends: libpve-network-perl (>= 0.9~),
> proxmox-firewall,
> proxmox-offline-mirror-helper,
> --
> 2.46.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-13 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 14:25 Jing Luo via pve-devel
2024-09-13 10:09 ` Fabian Grünbichler [this message]
2024-09-13 10:55 ` [pve-devel] [PATCH pve-manager v2] " Jing Luo via pve-devel
2024-11-11 22:35 ` [pve-devel] applied: " Thomas Lamprecht
[not found] ` <20240913110157.1454303-2-jing@jing.rocks>
2024-09-23 3:29 ` [pve-devel] Fwd: [RESEND PATCH " Jing Luo via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134670684.29789.1726222159650@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=jing@jing.rocks \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.