all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 2/2] ui: add Traffic Control UI
Date: Sat, 20 Nov 2021 22:57:50 +0100	[thread overview]
Message-ID: <1124a2a3-81d5-0bd4-29d5-bb0305888ce7@proxmox.com> (raw)
In-Reply-To: <20211119144227.1337999-4-d.csapak@proxmox.com>

On 19.11.21 15:42, Dominik Csapak wrote:
> adds a list of traffic control rules (with their current usage)
> and let the user add/edit/remove them
> 
> the edit window currently has a grid for timeframes to add/remove
> with input fields for start/endtime and checkboxes for the days
> 
> there are still some improvements possible, like having a seperate
> grid for networks (the input field is maybe too small), or
> optimizing consecutive days to a range (e.g. mon..wed instead of mon,tue,wed)
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/Makefile                     |   2 +
>  www/NavigationTree.js            |   6 +
>  www/config/TrafficControlView.js | 197 +++++++++++++
>  www/window/TrafficControlEdit.js | 464 +++++++++++++++++++++++++++++++
>  4 files changed, 669 insertions(+)
>  create mode 100644 www/config/TrafficControlView.js
>  create mode 100644 www/window/TrafficControlEdit.js
> 
>

applied, thanks! Made a few follow ups for some bug fixes (e.g., for empty/no
timeframes on add/edit) and adapted it to the HumanByte change of the backend.

We can still go with bytes only if we think this is not a good idea (I won't
upload any changes to public yet til at least Monday).




      reply	other threads:[~2021-11-20 21:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 14:42 [pbs-devel] [PATCH widget-toolkit/proxmox-backup] implement traffic-control ui Dominik Csapak
2021-11-19 14:42 ` [pbs-devel] [PATCH widget-toolkit 1/1] form: copy BandwidthSelector/SizeField from PVE Dominik Csapak
2021-11-19 15:12   ` [pbs-devel] applied: " Thomas Lamprecht
2021-11-19 14:42 ` [pbs-devel] [PATCH proxmox-backup 1/2] api: traffic_control: add missing rename to 'kebab-case' Dominik Csapak
2021-11-20 21:47   ` [pbs-devel] applied: " Thomas Lamprecht
2021-11-19 14:42 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: add Traffic Control UI Dominik Csapak
2021-11-20 21:57   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1124a2a3-81d5-0bd4-29d5-bb0305888ce7@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal