From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/3] backup client progress log interval
Date: Tue, 22 Oct 2024 07:35:06 +0200 [thread overview]
Message-ID: <10dd7bc5-fc82-4fb7-8c26-184469788135@proxmox.com> (raw)
In-Reply-To: <22e250cd-25f2-4313-b848-be04bf1f565b@proxmox.com>
Am 21/10/2024 um 18:06 schrieb Christian Ebner:
> If going for two different optional parameters, one question remains
> however: how to handle the no logging case? Should a 0 value indicate
> that or do we want another explicit flag for that?
Adding new variants is easier than removing existing ones, so for now
I'd go with using a zero interval for that.
If there are requests we can add either a special value, or maybe even
nicer a separate `--no-progress-log` switch, or with a similar name,
like e.g. an alternative could be `--no-progress-interval`.
>> Oh, and in above examples I also dropped the "log" as while it certainly
>> doesn't hurt its IMO also not really required to be able to understand what
>> it's for.
>
> Agreed! Thank you for your comments.
After having written above w.r.t. the disable-switch option I see a bit
more value in having "log" compared to yesterday, but no hard feelings
either way, let's not get hung up on this – you decide.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-10-22 5:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 12:55 Christian Ebner
2024-10-21 12:55 ` [pbs-devel] [PATCH proxmox-backup 1/3] api-types: client: add type to specify " Christian Ebner
2024-10-21 12:55 ` [pbs-devel] [PATCH proxmox-backup 2/3] client: progress log: factor out log message generation Christian Ebner
2024-10-21 12:55 ` [pbs-devel] [PATCH proxmox-backup 3/3] client: progress log: allow to specify backup log interval Christian Ebner
2024-10-21 15:08 ` [pbs-devel] [PATCH proxmox-backup 0/3] backup client progress " Thomas Lamprecht
2024-10-21 16:06 ` Christian Ebner
2024-10-22 5:35 ` Thomas Lamprecht [this message]
2024-10-23 9:12 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10dd7bc5-fc82-4fb7-8c26-184469788135@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.