* [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section
@ 2023-02-23 15:25 Lukas Wagner
2023-02-23 15:54 ` Stefan Sterz
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Lukas Wagner @ 2023-02-23 15:25 UTC (permalink / raw)
To: pve-devel
Sometimes it can be quite useful to know when exactly a system report
was generated. Adds the following output quite prominently in the
general system info section:
# date -R
Thu, 23 Feb 2023 16:21:12 +0100
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
PVE/Report.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/Report.pm b/PVE/Report.pm
index d363c15b..c9109dca 100644
--- a/PVE/Report.pm
+++ b/PVE/Report.pm
@@ -29,6 +29,7 @@ my $init_report_cmds = sub {
order => 10,
cmds => [
'hostname',
+ 'date -R',
'pveversion --verbose',
'cat /etc/hosts',
'pvesubscription get',
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section
2023-02-23 15:25 [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section Lukas Wagner
@ 2023-02-23 15:54 ` Stefan Sterz
2023-02-23 16:00 ` Lukas Wagner
2023-03-27 13:16 ` Lukas Wagner
2023-03-27 13:30 ` [pve-devel] applied: " Thomas Lamprecht
2 siblings, 1 reply; 5+ messages in thread
From: Stefan Sterz @ 2023-02-23 15:54 UTC (permalink / raw)
To: Proxmox VE development discussion, Lukas Wagner
On 2/23/23 16:25, Lukas Wagner wrote:
> Sometimes it can be quite useful to know when exactly a system report
> was generated. Adds the following output quite prominently in the
> general system info section:
>
While I agree that this can be useful sometimes, just as a heads-up,
iptables-save provides that info already:
# Generated by iptables-save v1.8.7 on Thu Feb 23 16:43:26 2023
However, we may not want to rely on that.
> # date -R
> Thu, 23 Feb 2023 16:21:12 +0100
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> PVE/Report.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index d363c15b..c9109dca 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -29,6 +29,7 @@ my $init_report_cmds = sub {
> order => 10,
> cmds => [
> 'hostname',
> + 'date -R',
> 'pveversion --verbose',
> 'cat /etc/hosts',
> 'pvesubscription get',
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section
2023-02-23 15:54 ` Stefan Sterz
@ 2023-02-23 16:00 ` Lukas Wagner
0 siblings, 0 replies; 5+ messages in thread
From: Lukas Wagner @ 2023-02-23 16:00 UTC (permalink / raw)
To: Stefan Sterz, Proxmox VE development discussion
On 2/23/23 16:54, Stefan Sterz wrote:
> While I agree that this can be useful sometimes, just as a heads-up,
> iptables-save provides that info already:
>
> # Generated by iptables-save v1.8.7 on Thu Feb 23 16:43:26 2023
>
> However, we may not want to rely on that.
>
Thanks for the feedback!
I am aware of the iptables output, I just thought it would be nice to have the
"tuple" (hostname, date) right at the start. Additionally, I have submitted patches
for PBS and PMG as well, to have the same info for all three products.
--
- Lukas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section
2023-02-23 15:25 [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section Lukas Wagner
2023-02-23 15:54 ` Stefan Sterz
@ 2023-03-27 13:16 ` Lukas Wagner
2023-03-27 13:30 ` [pve-devel] applied: " Thomas Lamprecht
2 siblings, 0 replies; 5+ messages in thread
From: Lukas Wagner @ 2023-03-27 13:16 UTC (permalink / raw)
To: pve-devel
On 2/23/23 16:25, Lukas Wagner wrote:
> Sometimes it can be quite useful to know when exactly a system report
> was generated. Adds the following output quite prominently in the
> general system info section:
>
> # date -R
> Thu, 23 Feb 2023 16:21:12 +0100
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> PVE/Report.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index d363c15b..c9109dca 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -29,6 +29,7 @@ my $init_report_cmds = sub {
> order => 10,
> cmds => [
> 'hostname',
> + 'date -R',
> 'pveversion --verbose',
> 'cat /etc/hosts',
> 'pvesubscription get',
Ping. The same change was already merged into PBS and PMG, so it would be good to have it
in PVE system reports as well.
--
- Lukas
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pve-devel] applied: [PATCH manager] pvereport: add `date -R` to general system info section
2023-02-23 15:25 [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section Lukas Wagner
2023-02-23 15:54 ` Stefan Sterz
2023-03-27 13:16 ` Lukas Wagner
@ 2023-03-27 13:30 ` Thomas Lamprecht
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2023-03-27 13:30 UTC (permalink / raw)
To: Proxmox VE development discussion, Lukas Wagner
Am 23/02/2023 um 16:25 schrieb Lukas Wagner:
> Sometimes it can be quite useful to know when exactly a system report
> was generated. Adds the following output quite prominently in the
> general system info section:
>
> # date -R
> Thu, 23 Feb 2023 16:21:12 +0100
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> PVE/Report.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-27 13:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-23 15:25 [pve-devel] [PATCH manager] pvereport: add `date -R` to general system info section Lukas Wagner
2023-02-23 15:54 ` Stefan Sterz
2023-02-23 16:00 ` Lukas Wagner
2023-03-27 13:16 ` Lukas Wagner
2023-03-27 13:30 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal