From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shannon Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] 8 to 9: use more robust systemd version parsing regex from pve-container
Date: Thu, 7 Aug 2025 14:56:42 +0200 [thread overview]
Message-ID: <106f30b8-9a89-4d0c-b45e-0cd8259344ea@proxmox.com> (raw)
In-Reply-To: <20250806134843.266183-1-s.sterz@proxmox.com>
Am 06.08.25 um 3:49 PM schrieb Shannon Sterz:
> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
> index 994189f13..a7ee842de 100644
> --- a/PVE/CLI/pve8to9.pm
> +++ b/PVE/CLI/pve8to9.pm
> @@ -1282,7 +1282,8 @@ sub check_containers_cgroup_compat {
> last if defined($libsd);
> }
> if (
> - defined($libsd) && $libsd =~ /libsystemd-shared-(\d+)(\.\d-\d)?(\.fc\d\d)?\.so/
> + defined($libsd)
> + && $libsd =~ /libsystemd-shared-(\d+)(?:[-.][a-zA-Z0-9]+)*\.so:?$/
I guess the colon at the very end is there, because in pve-container we
check via objdump rather than checking paths? It's already optional so
wouldn't be a functional change, but wanted to make sure.
Since we already use
my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir);
below, can't we simply call
$lxc_setup->unified_cgroupv2_support()
directly like we do in the prestart hook?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-07 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 13:48 Shannon Sterz
2025-08-07 12:56 ` Fiona Ebner [this message]
2025-08-07 14:23 ` [pve-devel] Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=106f30b8-9a89-4d0c-b45e-0cd8259344ea@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.