Re: [pbs-devel] [RFC proxmox-backup v3 0/2] more flexible HumanByte type

Re: [pbs-devel] [RFC proxmox-backup v3 0/2] more flexible HumanByte type

[Dietmar Maurer]

Another solution would be to simply use MiB/s as base unit in traffic-control.cfg, and store it as a simple float number.

This is less flexible, but much simpler to implement...

Any thought on that?

Re: [pbs-devel] [RFC proxmox-backup v3 0/2] more flexible HumanByte type

[Fabian Ebner]

Am 18.11.21 um 08:29 schrieb Dietmar Maurer:
> Changes since v2:
> 
>   - reverted changes from v2

Should there be separate types for byte rates that are represented with 
float + unit, and for byte sizes that are represented with an integer 
internally? After all, 1.2MiB/s "exists", but 1.2MiB does not ;)

> 
>   - restrict number of possibleunits (always store KB instead of K)
>   
>   - store size without scaling to unit (avoid rounding errors in
>     deserialze/serialze)
> 
>   - allow to specify precision in Display
> 
>   - new with_unit() constructor
> 
>   - improved dev docs
> 
> Changes since v1:
> 
> - do not expose auto_unit functions
> - store size as u64 (suggested by thomas)
> - do not store unit (suggested by thomas)
> 
> 
> *** BLURB HERE ***
> 
> Dietmar Maurer (2):
>    pbs-api-types: more flexible HumanByte type
>    use HumanByte for traffic-control config
> 
>   pbs-api-types/src/human_byte.rs      | 353 +++++++++++++++++++++++++++
>   pbs-api-types/src/lib.rs             |   3 +
>   pbs-api-types/src/traffic_control.rs |  18 +-
>   pbs-client/src/backup_writer.rs      |  19 +-
>   pbs-datastore/src/datastore.rs       |  13 +-
>   pbs-tools/Cargo.toml                 |   1 +
>   pbs-tools/src/format.rs              |  55 +----
>   src/bin/proxmox-tape.rs              |   7 +-
>   src/cached_traffic_control.rs        |  18 +-
>   src/server/email_notifications.rs    |   5 +-
>   10 files changed, 403 insertions(+), 89 deletions(-)
>   create mode 100644 pbs-api-types/src/human_byte.rs
> 

[pbs-devel] [RFC proxmox-backup v3 0/2] more flexible HumanByte type

[Dietmar Maurer]

Changes since v2:

 - reverted changes from v2

 - restrict number of possibleunits (always store KB instead of K)
 
 - store size without scaling to unit (avoid rounding errors in
   deserialze/serialze)

 - allow to specify precision in Display

 - new with_unit() constructor

 - improved dev docs

Changes since v1:

- do not expose auto_unit functions
- store size as u64 (suggested by thomas)
- do not store unit (suggested by thomas)


*** BLURB HERE ***

Dietmar Maurer (2):
  pbs-api-types: more flexible HumanByte type
  use HumanByte for traffic-control config

 pbs-api-types/src/human_byte.rs      | 353 +++++++++++++++++++++++++++
 pbs-api-types/src/lib.rs             |   3 +
 pbs-api-types/src/traffic_control.rs |  18 +-
 pbs-client/src/backup_writer.rs      |  19 +-
 pbs-datastore/src/datastore.rs       |  13 +-
 pbs-tools/Cargo.toml                 |   1 +
 pbs-tools/src/format.rs              |  55 +----
 src/bin/proxmox-tape.rs              |   7 +-
 src/cached_traffic_control.rs        |  18 +-
 src/server/email_notifications.rs    |   5 +-
 10 files changed, 403 insertions(+), 89 deletions(-)
 create mode 100644 pbs-api-types/src/human_byte.rs

-- 
2.30.2