* Re: [pbs-devel] [PATCH 0/3] Add cache for live-restore
@ 2021-04-28 16:14 Dietmar Maurer
0 siblings, 0 replies; 2+ messages in thread
From: Dietmar Maurer @ 2021-04-28 16:14 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Stefan Reiter
> Quantitative benchmarking appears really hard, variance between live-restore
> runs is really high for some reason (both time-to-desktop and time-to-finish).
> On average it seems to be between equal and up to 30% faster - again, with a lot
> of variance between runs.
Please can you try to find the reason for that? IMHO, there should not be
much variance between runs.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] [PATCH 0/3] Add cache for live-restore
@ 2021-04-28 16:06 Stefan Reiter
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Reiter @ 2021-04-28 16:06 UTC (permalink / raw)
To: pbs-devel
Adds a mmap-backed buffer (as suggested by Dietmar to avoid memory starvation)
of 64+256 MiB for accessing chunks from PBS. Helps to accelerate live-restore.
Quantitative benchmarking appears really hard, variance between live-restore
runs is really high for some reason (both time-to-desktop and time-to-finish).
On average it seems to be between equal and up to 30% faster - again, with a lot
of variance between runs.
In testing with a Windows VM I saw cache hit rates of about 25% or higher, so
the cache is certainly used, but there seem to be too many other factors in
play...
proxmox-backup: Stefan Reiter (2):
tools: add mmap_buffer module
RemoteChunkReader: add LRU cached variant
src/bin/proxmox_backup_client/mount.rs | 12 ++-
src/client/remote_chunk_reader.rs | 110 ++++++++++++++++++++----
src/tools.rs | 1 +
src/tools/mmap_buffer.rs | 113 +++++++++++++++++++++++++
4 files changed, 218 insertions(+), 18 deletions(-)
create mode 100644 src/tools/mmap_buffer.rs
proxmox-backup-qemu: Stefan Reiter (1):
access: use bigger cache and LRU chunk reader
src/restore.rs | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-28 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28 16:14 [pbs-devel] [PATCH 0/3] Add cache for live-restore Dietmar Maurer
-- strict thread matches above, loose matches on Subject: below --
2021-04-28 16:06 Stefan Reiter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal