all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v4 0/3] fix #4315: datastore: Exclude entries from sync
Date: Fri, 15 Dec 2023 09:45:28 +0100	[thread overview]
Message-ID: <0fd7c3ba-7c5f-470b-857c-01230a71633d@proxmox.com> (raw)
In-Reply-To: <62cc0327-cae3-4f4d-a5c0-259dae45efdd@proxmox.com>



On 12/14/23 17:22, Lukas Wagner wrote:
> Hi,
> 
> quickly tested these changes. Seems to work mostly fine, however ...
> 
> On 12/4/23 11:04, Philipp Hufnagl wrote:
>> This allows to use Group Filter for sync jobs so matches can not
>> just be
>> included but also excluded. For this the "group-filter" configuration
>> syntax has been extended with an optional "behaviour" parameter.
>> this can be "include" or "exclude". First, all include filter will be
>> applied, then all exclude filter. If no include filters exist, all will
>> be considered included.
>>
>> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
>> ---
>>
>> Changes since v3:
>>   * increase size of delete icon
>>   * include all when only exclude filter exist
> 
> ... this version changes the behavior when only INCLUDES exist...
>  - before: No groups, except those which match the include filters
>  - with these patches: All groups are included
> 
> 

Thats strange. I actually tested this. Ill check againn and send a new
patch.




  reply	other threads:[~2023-12-15  8:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 10:04 Philipp Hufnagl
2023-12-04 10:04 ` [pbs-devel] [PATCH proxmox-backup v4 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked Philipp Hufnagl
2023-12-14 16:22   ` Lukas Wagner
2023-12-15  9:44   ` Lukas Wagner
2023-12-15  9:47     ` Philipp Hufnagl
2023-12-04 10:04 ` [pbs-devel] [PATCH proxmox-backup v4 2/3] ui: Show if Filter includes or excludes Philipp Hufnagl
2023-12-04 10:04 ` [pbs-devel] [PATCH proxmox-backup v4 3/3] docs: document new include/exclude paramenter Philipp Hufnagl
2023-12-14 16:22 ` [pbs-devel] [PATCH proxmox-backup v4 0/3] fix #4315: datastore: Exclude entries from sync Lukas Wagner
2023-12-15  8:45   ` Philipp Hufnagl [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-11-28 14:34 Philipp Hufnagl
2023-11-28 14:48 ` Philipp Hufnagl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fd7c3ba-7c5f-470b-857c-01230a71633d@proxmox.com \
    --to=p.hufnagl@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal