* [pve-devel] [PATCH installer] gui: make abort button unsensitive on last panel
@ 2023-06-21 9:57 Maximiliano Sandoval
2023-06-21 10:51 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2023-06-21 9:57 UTC (permalink / raw)
To: pve-devel
It makes no sense from a UX point of view to abort an install that's
already finished.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
proxinstall | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/proxinstall b/proxinstall
index 6d13892..bf88b31 100755
--- a/proxinstall
+++ b/proxinstall
@@ -213,6 +213,7 @@ sub create_main_window {
$gtk_state->{next_btn} = $next_btn;
$gtk_state->{progress_bar} = Gtk3::ProgressBar->new();
$gtk_state->{progress_status} = Gtk3::Label->new('');
+ $gtk_state->{abort_btn} = $abort;
Proxmox::UI::init_gtk($gtk_state, $iso_env);
@@ -1522,6 +1523,10 @@ sub create_extract_view {
return $raw_html;
};
+ # It does not make sense to Abort the install at this point, whether it
+ # succeded or failed makes no difference.
+ $gtk_state->{abort_btn}->set_sensitive(0);
+
if ($err) {
Proxmox::UI::display_html("fail.htm");
# suppress "empty" error as we got some case where the user choose to abort on a prompt,
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH installer] gui: make abort button unsensitive on last panel
2023-06-21 9:57 [pve-devel] [PATCH installer] gui: make abort button unsensitive on last panel Maximiliano Sandoval
@ 2023-06-21 10:51 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-06-21 10:51 UTC (permalink / raw)
To: Proxmox VE development discussion, Maximiliano Sandoval
Am 21/06/2023 um 11:57 schrieb Maximiliano Sandoval:
> It makes no sense from a UX point of view to abort an install that's
> already finished.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> proxinstall | 5 +++++
> 1 file changed, 5 insertions(+)
>
>
applied, thanks!
(albeit it's a bit scary to press on reboot if one is testing just the GUI on their
workstation, outside of the installer, luckily we just quit in that case ;-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-21 10:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-21 9:57 [pve-devel] [PATCH installer] gui: make abort button unsensitive on last panel Maximiliano Sandoval
2023-06-21 10:51 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal