From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] applied: [PATCH pve-common 1/1] inotify/interfaces: use 'ip link' instead of /proc/net/dev
Date: Wed, 23 Jul 2025 17:16:54 +0200 [thread overview]
Message-ID: <0ea3edeb-a110-455e-812e-7b9f019d6c77@proxmox.com> (raw)
In-Reply-To: <175328294843.3720382.10504362558256531970.b4-ty@proxmox.com>
On 7/23/25 17:06, Thomas Lamprecht wrote:
[snip]
> I do not recall for sure anymore, but do differing bridge-ports work
> transparently with the ifupdown2 changes from Christoph. With that it might be
> nice to support it here too in the midterm, but that is certainly not a blocker
> for now.
I'm not sure if I understand 100% - do you mean if the name used in
bridge-ports differs from the name of the referenced interface in
/e/n/i? That doesn't work currently, since the validation breaks.
I've discussed this initially with Dominik today, and we'd need to
resolve altnames every time we look up names from bridge-ports, etc.
If we want to support mixing names in the configuration, then we'd
additionally have to construct a temporary, merged, configuration and
validate against that.
> Applied with perltidy formatting changes squashed in, thanks!
I will pay more attention to running `make tidy` in the future, still
not used to the fact that we actually have a formatter now - sorry.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-23 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 14:21 [pve-devel] " Stefan Hanreich
2025-07-23 15:02 ` [pve-devel] applied: " Thomas Lamprecht
2025-07-23 15:16 ` Stefan Hanreich [this message]
2025-07-23 15:33 ` Thomas Lamprecht
2025-07-23 15:53 ` Stefan Hanreich
2025-07-23 15:57 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea3edeb-a110-455e-812e-7b9f019d6c77@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.