From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-flutter-frontend] fix text selection theme
Date: Mon, 12 Sep 2022 17:07:06 +0200 [thread overview]
Message-ID: <0e520ecb-7e00-2c6d-e7bd-4063c7efce34@proxmox.com> (raw)
In-Reply-To: <20220912092403.1608055-1-d.csapak@proxmox.com>
Am 12/09/2022 um 11:24 schrieb Dominik Csapak:
> by default, flutter derives the text selection theme from the global
> MaterialApp defined themes primary color, which is problematic in our
> case, since we often have the same primary color as background for text
> fields. This resulted in the cursorColor/selectionHandleColor to be the
> same as the background, making them invisible.
>
> Fix it by creating a manual textSelectionTheme with colors that properly
> contrast the background. (The color works well for both light and dark mode)
>
> The selectionHandleColor is modifed with an opacity of 0.4 like flutter
> does by default.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> lib/main.dart | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2022-09-12 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 9:24 [pve-devel] " Dominik Csapak
2022-09-12 15:07 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e520ecb-7e00-2c6d-e7bd-4063c7efce34@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal