From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied-series: [PATCH v2 pve-manager pve-docs 0/4] add optional WoL config options
Date: Fri, 29 Mar 2024 08:44:56 +0100 [thread overview]
Message-ID: <0e41e49a-2469-4e25-b5f8-a55fc616f39c@proxmox.com> (raw)
In-Reply-To: <6c8f7a40-98b1-47dd-b981-08562ef59a49@proxmox.com>
On 3/28/24 18:27, Thomas Lamprecht wrote:
>
> applied, thanks!
>
> I did some very minor follow-ups mostly to document the current default in
> the schema and docs and a small style fix (well not even really style wise,
> but rather making the part with assigning and checking the $bind_interface
> variable slightly shorter).
Ah yes, that is indeed more compact :)
>
> While this is slightly niche it might still make sense to add this to the
> web UI too (WoL is exposed via Node -> Options) for completeness sake.
Will send a patch for editing the properties via the UI as well, thanks
for the hint.
prev parent reply other threads:[~2024-03-29 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 9:16 [pve-devel] " Christian Ebner
2024-03-26 9:16 ` [pve-devel] [PATCH v2 pve-manager 1/4] node: config: make wakeonlan a property string Christian Ebner
2024-03-26 9:16 ` [pve-devel] [PATCH v2 pve-manager 2/4] fix #5255: node: wol: add optional bind interface Christian Ebner
2024-03-26 9:16 ` [pve-devel] [PATCH v2 pve-manager 3/4] fix #5255: node: wol: configurable broadcast address Christian Ebner
2024-03-26 9:16 ` [pve-devel] [PATCH v2 pve-docs 4/4] pvenode/wake-on-lan: mention optional config options Christian Ebner
2024-03-28 17:27 ` [pve-devel] applied-series: [PATCH v2 pve-manager pve-docs 0/4] add optional WoL " Thomas Lamprecht
2024-03-29 7:44 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e41e49a-2469-4e25-b5f8-a55fc616f39c@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.