[pdm-devel] [PATCH datacenter-manager] server: api: acme: fix certificate ordering when no account is set

[pdm-devel] [PATCH datacenter-manager] server: api: acme: fix certificate ordering when no account is set

[Dominik Csapak]

in case no account is set, the assumption is that we want to use the
'default' account. Since the `AcmeConfig` has no default_key set,
the format `account=default` is required.

was reported in the forum:
https://forum.proxmox.com/threads/166092/

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
alternatively, we could set the default_key there, but this format is
the same as it lands in the config

 server/src/api/nodes/certificates.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/src/api/nodes/certificates.rs b/server/src/api/nodes/certificates.rs
index 3d9ac82..52c2ae3 100644
--- a/server/src/api/nodes/certificates.rs
+++ b/server/src/api/nodes/certificates.rs
@@ -270,7 +270,7 @@ fn spawn_certificate_worker(
     let acme_config = if let Some(cfg) = cert_config.acme_config().transpose()? {
         cfg
     } else {
-        proxmox_acme_api::parse_acme_config_string("default")?
+        proxmox_acme_api::parse_acme_config_string("account=default")?
     };
 
     WorkerTask::spawn(name, None, auth_id, true, move |worker| async move {
@@ -317,7 +317,7 @@ pub fn revoke_acme_cert(rpcenv: &mut dyn RpcEnvironment) -> Result<String, Error
     let acme_config = if let Some(cfg) = cert_config.acme_config().transpose()? {
         cfg
     } else {
-        proxmox_acme_api::parse_acme_config_string("default")?
+        proxmox_acme_api::parse_acme_config_string("account=default")?
     };
 
     WorkerTask::spawn(
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager] server: api: acme: fix certificate ordering when no account is set

[Dominik Csapak]

ping


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] applied: [PATCH datacenter-manager] server: api: acme: fix certificate ordering when no account is set

[Thomas Lamprecht]

On Tue, 13 May 2025 13:56:43 +0200, Dominik Csapak wrote:
> in case no account is set, the assumption is that we want to use the
> 'default' account. Since the `AcmeConfig` has no default_key set,
> the format `account=default` is required.
> 
> was reported in the forum:
> https://forum.proxmox.com/threads/166092/
> 
> [...]

I run into this to recently and fixed the instance for ordering a cert,
but the one for revoking was still broken, so applied your patch in a
three-way merge on the current master, thanks!

[1/1] server: api: acme: fix certificate ordering when no account is set
      commit: 57c7f94399e673e9dba840b524694340b1b90c0e


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel