From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH installer] fix #5973: auto: first boot: allow snake- and kebabcased property names
Date: Thu, 30 Jan 2025 11:06:41 +0100 [thread overview]
Message-ID: <0dec173a-da75-4d70-ac07-e1133c136081@proxmox.com> (raw)
In-Reply-To: <f70a0113-a09e-4590-ad9a-beb1b67ef3be@proxmox.com>
Am 30.01.25 um 10:11 schrieb Daniel Kral:
> I also like that solution and that is more in line with the motivation
> behind the patch. I could queue up a patch for the next ISO release, so
> that it's indifferent to the user whether they write the config
> parameter names in their answer files in the old snake case or new
> kebab-case format.
Yes, please do.
> I'd prefer a single serde attribute for that rather than rename_all +
> alias at every property, if that's possible in a few lines, as it would
> be cleaner and we don't have to look at every property whether it's
> missing a alias attribute or not.
FWIW, you need to check out all structs that get serialized or are
member of such a struct anyway, and most are relatively small, so looking
at every property is not a big problem I think.
In the long term we might go back to a single variant to reduce complexity
for us and users. I'd target a relatively slow deprecation period for that
though, like e.g., allow both for Bookworm (e.g. PVE 8) and Trixie (e.g.
PVE 9) based releases but print a deprecation notice starting with Trixie
based releases and then drop support for the snake_case with Forky (e.g.
PVE 10) based releases.
Would be also good to know if there is any usage of snake_case for things
we send out, like the system info or post installation hook stuff.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-01-30 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 14:07 Daniel Kral
2025-01-28 14:38 ` Thomas Lamprecht
2025-01-29 9:34 ` Christoph Heiss
2025-01-30 9:11 ` Daniel Kral
2025-01-30 10:06 ` Thomas Lamprecht [this message]
2025-02-17 12:21 ` Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dec173a-da75-4d70-ac07-e1133c136081@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.