all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH docs] qm: pci passthrough: correct note about using 'softdep'
Date: Tue, 24 Feb 2026 12:28:12 +0100	[thread overview]
Message-ID: <0d2e34b4-2ff0-43f4-959e-8ad74f56205c@proxmox.com> (raw)
In-Reply-To: <20251219083102.623503-1-d.csapak@proxmox.com>

Am 19.12.25 um 9:30 AM schrieb Dominik Csapak:
> In most cases with passthrough, the vfio-pci driver is preferred to what
> the kernel would normally load (e.g. amdgpu/nouveau), so 'softdep' can
> be used to make sure 'vfio-pci' is loaded before the actual module.
> 
> This is expressed in our docs already with a sensible example, but the
> text is wrong, since it says 'load the gpu modules *before* loading
> vfio-pci'.
> 
> So simply correct the 'before' to 'after'.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  qm-pci-passthrough.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
> index 52b1d58..3520983 100644
> --- a/qm-pci-passthrough.adoc
> +++ b/qm-pci-passthrough.adoc
> @@ -254,7 +254,7 @@ xref:qm_pci_passthrough_update_initramfs[update the `initramfs`] again and
>  reboot after that.
>  
>  Should this not work, you might need to set a soft dependency to load the gpu
> -modules before loading 'vfio-pci'. This can be done with the 'softdep' flag, see
> +modules after loading 'vfio-pci'. This can be done with the 'softdep' flag, see
>  also the manpages on 'modprobe.d' for more information.
>  
>  For example, if you are using drivers named <some-module>:

Since the example uses "pre: vfio-pci", do you have any objection to
also formulate the sentence here to match this:

"...soft dependency to load 'vfio-pci' before loading the GPU modules."

?




  reply	other threads:[~2026-02-24 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19  8:30 Dominik Csapak
2026-02-24 11:28 ` Fiona Ebner [this message]
2026-02-24 11:30   ` Dominik Csapak
2026-02-24 11:40 ` applied: " Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d2e34b4-2ff0-43f4-959e-8ad74f56205c@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal