From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/access-control/proxmox-widget-toolkit v1 0/4] fix #4546: Show warning hint/badge if user account is expiring in next few days
Date: Mon, 9 Oct 2023 15:07:06 +0200 [thread overview]
Message-ID: <0d2b2c1a-9037-4524-b3d1-8d3b34015b00@proxmox.com> (raw)
In-Reply-To: <7de71173-6944-4842-9f3f-56250b34fd95@proxmox.com>
On 10/6/23 15:16, Lukas Wagner wrote:
>
>
> On 9/22/23 16:36, Philipp Hufnagl wrote:
>> Currently, when an user account expires, it catches the users by
>> surprise. It would be helpful to notify the the user as well as the
>> administrator.
>>
>> This patch highlights such accounts in the user account pannel and also
>> shows for regular user an exclamation mark in the user info pannel. It
>> also adds in this case a new entry briefly saing that the account
>> expires. When this entry is clicked it states this in more detail
>> including the experation date.
>>
>> Sending this for PVE only now to get feedback before implementing this
>> for PMG and PBS
>>
>
> Tested this on the latest master. Seems to work as adverised with the
> exception of a small rendering bug (decribed in one of the other
> messages).
>
>
>
Thanks for all the valuable feedback! I am currently working on a v2.
Please don't merge!
prev parent reply other threads:[~2023-10-09 13:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 14:36 Philipp Hufnagl
2023-09-22 14:36 ` [pve-devel] [PATCH manager v1 1/1] fix #4546: ui: notify user if their user account expires soon Philipp Hufnagl
2023-10-06 13:16 ` Lukas Wagner
2023-10-10 10:15 ` Philipp Hufnagl
2023-09-22 14:36 ` [pve-devel] [PATCH access-control v1 1/1] fix #4546: api: Return user expiration date on access/ticket API call Philipp Hufnagl
2023-10-06 13:16 ` Lukas Wagner
2023-09-22 14:36 ` [pve-devel] [PATCH proxmox-widget-toolkit v1 1/2] fix #4546: css: Inform user administrator about user accounts expiring soon Philipp Hufnagl
2023-10-06 13:16 ` Lukas Wagner
2023-10-06 14:41 ` Stefan Sterz
2023-10-10 10:18 ` Philipp Hufnagl
2023-09-22 14:36 ` [pve-devel] [PATCH proxmox-widget-toolkit v1 2/2] fix #4546: utils: save expiring date of user account for UI Philipp Hufnagl
2023-10-06 13:16 ` Lukas Wagner
2023-10-06 14:41 ` Stefan Sterz
2023-10-06 13:16 ` [pve-devel] [PATCH manager/access-control/proxmox-widget-toolkit v1 0/4] fix #4546: Show warning hint/badge if user account is expiring in next few days Lukas Wagner
2023-10-09 13:07 ` Philipp Hufnagl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d2b2c1a-9037-4524-b3d1-8d3b34015b00@proxmox.com \
--to=p.hufnagl@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.