[pve-devel] applied: [PATCH v2 pve-manager] fix #5936: ui: backup: add CT PBS change detection mode selector

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 29.11.24 um 16:00 schrieb Christian Ebner:
> Allow to select the change detection mode when performing manual
> backups of containers with Proxmox Backup Server as target, just like
> for the advanced backup job options introduced by commit 3b21f19f
> ("www: advanced backup: add pbs change detection mode selector").
> 
> The selector is shown for virtual machine and container backup in
> order to maintain the same layout for both, but only enabled for
> container backup with a Proxmox Backup Server selected as target
> storage.
> 
> Link to issue in bugtracker:
> https://bugzilla.proxmox.com/show_bug.cgi?id=5936
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Changes since version 1 (thanks @Shannon for feedback):
> - show selector for both, vm and ct to maintain layout, with the side
>   effect of requiring less conditional checks
> - show a tooltip icon above the selector, in order to explain under
>   which circumstances the mode takes effect. Note: This was placed above
>   as otherwise the text will not be shown on hover if the selector is in
>   disabled state.
> 
>  www/manager6/window/Backup.js | 36 +++++++++++++++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel