From: Christian Ebner <c.ebner@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup] client: catalog shell: avoid navigating below archive root
Date: Tue, 3 Sep 2024 14:38:56 +0200 [thread overview]
Message-ID: <0cb5e480-27dd-4934-9208-a9c5b147d119@proxmox.com> (raw)
In-Reply-To: <tdqxo3scjxukld5qpvv6zpoft4suju62dir7yhnkwju55gxnqg@g6myqmwgwl3w>
On 8/30/24 10:00, Wolfgang Bumiller wrote:
> On Thu, Aug 08, 2024 at 01:42:03PM GMT, Christian Ebner wrote:
>> Avoid to underflow the catalogs shell position stack by navigating
>> below the archives root directory into the catalog root. Otherwise
>> the shell will panic, as the root entry is always expected to be
>> present.
>>
>> This threats the archive root directory as being it's own parent
>> directory, mimicking the behaviour of most common shells.
>>
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>> Encountered while implementing the catalog shell for the split pxar
>> archive case.
>>
>> Without this additional check, a `cd ..` in the pxar archive root of
>> the catalog shell will panic.
>
>
> What about `cd ../../..` when *not* at a root, would we now ignore this
> without any error messages?
True, the case where the current working directory is not the root
directory is not handled correctly as is. Will send a new version of the
patch fixing that.
Thanks a lot!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-09-03 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 11:42 Christian Ebner
2024-08-30 8:00 ` Wolfgang Bumiller
2024-09-03 12:38 ` Christian Ebner [this message]
2024-09-03 12:41 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cb5e480-27dd-4934-9208-a9c5b147d119@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.