From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible
Date: Fri, 15 Dec 2023 09:50:20 +0100 [thread overview]
Message-ID: <0c7626c4-90f3-49e6-baa3-3b0cb5545722@proxmox.com> (raw)
In-Reply-To: <20231121151025.233224-1-m.sandoval@proxmox.com>
Hi,
On 11/21/23 16:10, Maximiliano Sandoval wrote:
> We replace the use of nested boxes with grids when possible to ensure correct
> margins and alignment of widgets.
>
> At the end we also remove trailing spaces and colons from labels preceding an
> input widget, e.g. we replace `DNS Server: ` with `DNS Server`.
>
Tested these changes against the latest master branch. I did not notice
any regressions.
Consider this:
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
--
- Lukas
next prev parent reply other threads:[~2023-12-15 8:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:10 Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 1/7] gui: move create_basic_grid subroutine definition up Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 2/7] gui: expand ip address Gtk3::Entry Maximiliano Sandoval
2023-12-15 12:06 ` Christoph Heiss
2023-12-15 14:08 ` Maximiliano Sandoval
2023-12-20 9:40 ` Christoph Heiss
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 3/7] gui: use basic grid in password panel Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 4/7] gui: use basic grid in country/timezone panel Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 5/7] gui: change margins in create_basic_grid Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 6/7] gui: use basic grid in the network panel Maximiliano Sandoval
2023-11-21 15:10 ` [pve-devel] [PATCH installer v2 7/7] gui: remove trailing spaces and colons Maximiliano Sandoval
2023-12-14 13:58 ` [pve-devel] [PATCH installer v2 0/7] gui: use gtk grids when possible Maximiliano Sandoval
2023-12-15 8:50 ` Lukas Wagner [this message]
2023-12-15 12:08 ` Christoph Heiss
2024-01-08 10:47 ` Maximiliano Sandoval
2024-02-14 13:32 ` Maximiliano Sandoval
2024-02-22 13:31 ` Maximiliano Sandoval
2024-02-23 13:16 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c7626c4-90f3-49e6-baa3-3b0cb5545722@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.