[pve-devel] [PATCH proxmox-firewall 1/2] clippy: useless use of `format!`

[pve-devel] [PATCH proxmox-firewall 1/2] clippy: useless use of `format!`

[Stefan Hanreich]

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 proxmox-firewall/src/firewall.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-firewall/src/firewall.rs b/proxmox-firewall/src/firewall.rs
index cdbe401..88fb460 100644
--- a/proxmox-firewall/src/firewall.rs
+++ b/proxmox-firewall/src/firewall.rs
@@ -96,7 +96,7 @@ impl Firewall {
     }
 
     fn guest_invalid_conntrack_chain() -> ChainPart {
-        ChainPart::new(Self::guest_table(), format!("invalid-conntrack"))
+        ChainPart::new(Self::guest_table(), "invalid-conntrack".to_string())
     }
 
     fn host_conntrack_chain() -> ChainPart {
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH proxmox-ve-rs 2/2] clippy: you should consider adding a `Default` implementation for `Group`

[Stefan Hanreich]

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
 proxmox-ve-config/src/firewall/types/group.rs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/proxmox-ve-config/src/firewall/types/group.rs b/proxmox-ve-config/src/firewall/types/group.rs
index 7455268..b9b71b6 100644
--- a/proxmox-ve-config/src/firewall/types/group.rs
+++ b/proxmox-ve-config/src/firewall/types/group.rs
@@ -9,6 +9,12 @@ pub struct Group {
     comment: Option<String>,
 }
 
+impl Default for Group {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl Group {
     pub const fn new() -> Self {
         Self {
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH proxmox-firewall 1/2] clippy: useless use of `format!`

[Thomas Lamprecht]

Am 25.11.24 um 17:18 schrieb Stefan Hanreich:
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  proxmox-firewall/src/firewall.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel