From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] pve7to8: reword and fix typos in description
Date: Thu, 18 Apr 2024 10:13:06 +0200 [thread overview]
Message-ID: <0c45d904-6a31-4d87-b77d-7d64df81ebf6@proxmox.com> (raw)
In-Reply-To: <D0N3BJEQ8DZX.RXNKX6QNEQ9Y@proxmox.com>
Am 18/04/2024 um 10:03 schrieb Stefan Sterz:
>> + before, and during the upgrade of a Proxmox VE system.\n" >> $@.tmp
>
> i know this is pre-existing, but since you are touching this anyway: the
> comma here is odd, if this was supposed to be an oxford comma (or serial
> comma), please be aware that these only apply in lists of three or more
> items. here we have two lists of two items, so the oxford comma does not
> apply.
yeah, that can be dropped – I often tend to go for the comma if I'm in
doubt, in a hurry, or the like... ^^
>
>> + printf "Any failures or warnings must be addressed prior to the upgrade.\n" >> $@.tmp
>> + printf "If you think that a message is a false-positive, check this carefully before proceeding.\n" >> $@.tmp
>
> again a matter of personal taste, but "check this carefully" sounds a
> bit clumsy to me. maybe "double-check that the tool is incorrect before
> proceeding".
I'd not suggest the tool being incorrect, rather that one should ensure that
the warning does not apply to one's setup.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-04-18 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 7:44 Alexander Zeidler
2024-04-18 8:03 ` Stefan Sterz
2024-04-18 8:13 ` Thomas Lamprecht [this message]
2024-04-18 8:33 ` Stefan Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c45d904-6a31-4d87-b77d-7d64df81ebf6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.