From: Daniel Kral <d.kral@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: cloudinit: disallow unprivileged users to regenerate images
Date: Thu, 7 Nov 2024 14:28:29 +0100 [thread overview]
Message-ID: <0c229677-34ac-4586-9342-0fec4d4586c0@proxmox.com> (raw)
In-Reply-To: <26371bea-2bd7-42d7-807a-21f2263073c4@proxmox.com>
On 11/4/24 13:02, Fiona Ebner wrote:
> Since those users can already use the cloudinit_update endpoint (just
> not via UI) and thus effectively don't need "VM.Config.CDROM", I think
> it's better to change the UI to use that endpoint as well.
>
> The endpoint was added here [0] and the switch in the UI was already
> proposed [1] as part of that but it seems never applied.
>
> [0]:
> https://lore.proxmox.com/pve-devel/20220622115206.3295425-1-aderumier@odiso.com/
>
> [1]:
> https://lore.proxmox.com/pve-devel/20220622141335.3616129-2-aderumier@odiso.com/
Thanks for pointing that out! I also think that it would be a better
solution. I've already applied the UI patches locally, but since the
cloudinit-related API endpoint's have been changed significantly since
then, I will update those parts of the patch and send it anew as a v2
with an added Originally-by trailer.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-07 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 14:06 Daniel Kral
2024-11-04 12:02 ` Fiona Ebner
2024-11-07 13:28 ` Daniel Kral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c229677-34ac-4586-9342-0fec4d4586c0@proxmox.com \
--to=d.kral@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.