[PATCH proxmox-backup] fix #7412: ui: dashboard: persist datastore usage column state

[PATCH proxmox-backup] fix #7412: ui: dashboard: persist datastore usage column state

[David Riley]

Store the state of the columns for the Datastore Usage Dashboard.
Ensures the column configuration is maintained across
page reloads and navigations instead of resetting to the default view.

Signed-off-by: David Riley <d.riley@proxmox.com>
---
 www/dashboard/DataStoreStatistics.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/dashboard/DataStoreStatistics.js b/www/dashboard/DataStoreStatistics.js
index c210d24d..7a33f49d 100644
--- a/www/dashboard/DataStoreStatistics.js
+++ b/www/dashboard/DataStoreStatistics.js
@@ -55,6 +55,8 @@ Ext.define('PBS.DatastoreStatistics', {
 
     title: gettext('Datastore Usage'),
     disableSelection: true,
+    stateful: true,
+    stateId: 'dashboard-grid-datastore-usage',
 
     emptyText: gettext('No Data'),
 
-- 
2.47.3

Re: [PATCH proxmox-backup] fix #7412: ui: dashboard: persist datastore usage column state

[Christian Ebner]

Thanks for the patch!

Only one nit inline, which may however be considered when applying.

Tested state is maintained on page refresh and survives a logout/login.

On 3/24/26 10:34 AM, David Riley wrote:
> Store the state of the columns for the Datastore Usage Dashboard.
> Ensures the column configuration is maintained across
> page reloads and navigations instead of resetting to the default view.
> 
> Signed-off-by: David Riley <d.riley@proxmox.com>
> ---

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7412
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>


>   www/dashboard/DataStoreStatistics.js | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/www/dashboard/DataStoreStatistics.js b/www/dashboard/DataStoreStatistics.js
> index c210d24d..7a33f49d 100644
> --- a/www/dashboard/DataStoreStatistics.js
> +++ b/www/dashboard/DataStoreStatistics.js
> @@ -55,6 +55,8 @@ Ext.define('PBS.DatastoreStatistics', {
>   
>       title: gettext('Datastore Usage'),
>       disableSelection: true,
> +    stateful: true,
> +    stateId: 'dashboard-grid-datastore-usage',

nit: other occurrences of `stateId` for grids in the PBS code base seem 
to typically follow the form `grid-{component-name}`, so this should be 
`grid-datastore-statistics`.

>   
>       emptyText: gettext('No Data'),
>   

superseded: [PATCH proxmox-backup] fix #7412: ui: dashboard: persist datastore usage column state

[David Riley]

superseded-by:
https://lore.proxmox.com/pbs-devel/20260326131837.28941-1-d.riley@proxmox.com/T/

On 3/24/26 10:34 AM, David Riley wrote:
> Store the state of the columns for the Datastore Usage Dashboard.
> Ensures the column configuration is maintained across
> page reloads and navigations instead of resetting to the default view.
>
> Signed-off-by: David Riley <d.riley@proxmox.com>
> ---
>   www/dashboard/DataStoreStatistics.js | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/www/dashboard/DataStoreStatistics.js b/www/dashboard/DataStoreStatistics.js
> index c210d24d..7a33f49d 100644
> --- a/www/dashboard/DataStoreStatistics.js
> +++ b/www/dashboard/DataStoreStatistics.js
> @@ -55,6 +55,8 @@ Ext.define('PBS.DatastoreStatistics', {
>   
>       title: gettext('Datastore Usage'),
>       disableSelection: true,
> +    stateful: true,
> +    stateId: 'dashboard-grid-datastore-usage',
>   
>       emptyText: gettext('No Data'),
>