From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Friedrich Weber <f.weber@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v3] ui: vm console: autodetect novnc or xtermjs
Date: Mon, 24 Mar 2025 18:25:59 +0100 [thread overview]
Message-ID: <0b04f946-fc5c-4108-85b9-3f099ff400d4@proxmox.com> (raw)
In-Reply-To: <c08a86ff-f1a8-4a27-bfa0-e6a940eb0cae@proxmox.com>
On 2025-03-24 17:57, Friedrich Weber wrote:
> On 25/02/2025 16:47, Aaron Lauterer wrote:
[…]
>> +
>> + if (me.consoleType ==="kvm") {
>
> nit: missing space after the ===
thanks for spotting this
>
>> + Proxmox.Utils.API2Request({
>> + url: `/api2/extjs/nodes/${me.nodename}/qemu/${me.vmid}/config`,
>
> Stumbled upon this by accident: I guess this could should pass
> `current=1` to get the currently running config instead of the config
> with pending changes applied (because the running config one is the
> relevant one for deciding whether to use noVNC or xterm.js).
good point. I'll send another version that will request the current config
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-24 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 15:47 Aaron Lauterer
2025-03-24 16:57 ` Friedrich Weber
2025-03-24 17:25 ` Aaron Lauterer [this message]
2025-03-25 8:10 ` Hannes Duerr
2025-03-25 9:20 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b04f946-fc5c-4108-85b9-3f099ff400d4@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal