all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH v3 stable-7+master manager 1/3] ui: vm selector: gracefully handle empty IDs in setValue function
Date: Wed, 27 Sep 2023 19:22:46 +0200	[thread overview]
Message-ID: <0ae3132c-d02e-4143-a41e-ab4e28819965@proxmox.com> (raw)
In-Reply-To: <20230925115841.47873-1-f.ebner@proxmox.com>

Am 25/09/2023 um 13:58 schrieb Fiona Ebner:
> An empty string is passed by the backup job window when using
> selection mode 'all', would be converted to [""] and wrongly add an
> entry with VMID 0 because the item "" could not be found in the store.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/130164/
> 
> Fixes: 7a5ca76a ("fix #4239: ui: show selected but non-existing vmids in backup edit")
> Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> It is enough to apply this or the second patch to stable-7 to fix the
> issue.
> 
> Changes in v3:
>     * use filter function to handle more general cases like "100,,200"
>       and not just the empty string.
> 
>  www/manager6/form/VMSelector.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied series and the first one also to stable-7, thanks!

ps. you got my OK for applying your own patches if there was positive
review/testing feedback.




      parent reply	other threads:[~2023-09-27 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 11:58 [pve-devel] " Fiona Ebner
2023-09-25 11:58 ` [pve-devel] [PATCH v3 manager 2/3] ui: vm selector: don't add invalid not found items Fiona Ebner
2023-09-25 11:58 ` [pve-devel] [PATCH v3 manager 3/3] ui: vm selector: gracefully handle undefined/null in setValue function Fiona Ebner
2023-09-27 17:22 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ae3132c-d02e-4143-a41e-ab4e28819965@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal