From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 manager 4/4] ui: storage backup view: add prune window
Date: Mon, 23 Nov 2020 07:08:54 +0100 [thread overview]
Message-ID: <0a4015a2-b07a-036c-1f67-31977f45949e@proxmox.com> (raw)
In-Reply-To: <20201118100420.21167-5-f.ebner@proxmox.com>
On 18.11.20 11:04, Fabian Ebner wrote:
> adapted from PBS. Main differences are:
> * loading of the prune-backups options from the storage configuration if
> configured
> * API has GET/DELETE distinction instead of 'dry-run'
> * API expects a single property string for the prune options
>
> Also, had to change the clear trigger, because now there can be original
> values (from the storage config), but it doesn't really make sense to
> reset to that value when clearing, so always set to 'null' when clearing
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Changes from v3:
> * don't use grouping headers with a prune button. Instead use a button in
> the toolbar which displays the group to be pruned
> * always use 'lxc' and 'qemu' as backup types (which the PVE API expects) instead
> of 'VM' and 'CT' as types, to avoid some conversion
>
I added the keep input field and a prune keep panel to proxmox-widget-toolkit,
so at least the input field should be reusable here.
next prev parent reply other threads:[~2020-11-23 6:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 10:04 [pve-devel] [PATCH-SERIES v4 manager] split up content view/add " Fabian Ebner
2020-11-18 10:04 ` [pve-devel] [PATCH v4 manager 1/4] cluster resources: include content type for storages Fabian Ebner
2020-11-18 10:04 ` [pve-devel] [PATCH v4 manager 2/4] ui: storage: get content types from resources Fabian Ebner
2020-11-18 10:04 ` [pve-devel] [PATCH v4 manager 3/4] ui: make remaining content views not stateful Fabian Ebner
2020-11-18 10:04 ` [pve-devel] [PATCH v4 manager 4/4] ui: storage backup view: add prune window Fabian Ebner
2020-11-23 6:08 ` Thomas Lamprecht [this message]
2020-11-23 6:09 ` [pve-devel] partially-applied: [PATCH-SERIES v4 manager] split up content view/add " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a4015a2-b07a-036c-1f67-31977f45949e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal