From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH container 1/1] status: add some missing descriptions for status return properties
Date: Thu, 24 Oct 2024 14:20:22 +0200 [thread overview]
Message-ID: <0a006d35-4f1c-40cd-a148-31e15ed27253@proxmox.com> (raw)
In-Reply-To: <20241021091542.1017657-3-d.csapak@proxmox.com>
Am 21/10/2024 um 11:15 schrieb Dominik Csapak:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PVE/LXC.pm | 43 ++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
>
applied, thanks! FYI: I had to fix a duplicate key (see below) and made a few
small adjustments to the wording (not just your additions) as a separate follow-up.
> + netin => {
> + description => "The amount of traffic that was sent to the guest since the process start,"
> + ." in bytes.",
> + type => 'integer',
> + optional => 1,
> + renderer => 'bytes',
> + },
> + netin => {
changed this to netout and folded that into your commit.
> + description => "The amount of traffic that was sent from the guest since the process start,"
> + ." in bytes.",
> + type => 'integer',
> + optional => 1,
> + renderer => 'bytes',
> + },
> uptime => {
> description => "Uptime.",
> type => 'integer',
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-10-24 12:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 9:15 [pve-devel] [PATCH qemu-server/container/manager] add some missing return schema descriptions Dominik Csapak
2024-10-21 9:15 ` [pve-devel] [PATCH qemu-server 1/1] status: add some missing description for status return properties Dominik Csapak
2024-10-24 13:53 ` [pve-devel] applied: " Thomas Lamprecht
2024-10-21 9:15 ` [pve-devel] [PATCH container 1/1] status: add some missing descriptions " Dominik Csapak
2024-10-24 12:20 ` Thomas Lamprecht [this message]
2024-10-24 15:05 ` [pve-devel] applied: " Dominik Csapak
2024-10-24 15:12 ` Thomas Lamprecht
2024-10-21 9:15 ` [pve-devel] [PATCH manager 1/2] api: subscription: add return schema for 'GET' api Dominik Csapak
2024-10-24 15:02 ` [pve-devel] applied: " Thomas Lamprecht
2024-10-21 9:15 ` [pve-devel] [PATCH manager 2/2] api: cluster/resources: add missing return properties Dominik Csapak
2024-10-24 15:02 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a006d35-4f1c-40cd-a148-31e15ed27253@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal