From: Fiona Ebner <f.ebner@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-network 1/1] sdn: api: route maps: fix json schema for match, set and exit-action
Date: Wed, 13 May 2026 10:15:26 +0200 [thread overview]
Message-ID: <09f5cf1a-16ec-49d4-a4de-2b412f385988@proxmox.com> (raw)
In-Reply-To: <20260512134336.312909-1-s.hanreich@proxmox.com>
Am 12.05.26 um 3:41 PM schrieb Stefan Hanreich:
> The 2 keys that can have a value in the exit-action both refer to the
> order number of a route map entry, so change the type to the
> pre-defined route map order type.
---snip 8<---
> @@ -187,11 +189,7 @@ sub route_map_properties {
> 'on-match-goto', 'on-match-next', 'continue',
> ],
> },
> - value => {
> - type => 'string',
> - optional => 1,
> - description => 'type of exit action',
> - },
> + value => get_standard_option('pve-sdn-route-map-order'),
Don't we need an ', { optional => 1 }' here?
> },
> optional => 1,
> },
next prev parent reply other threads:[~2026-05-13 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 13:43 [PATCH pve-network 1/1] sdn: api: route maps: fix json schema for match, set and exit-action Stefan Hanreich
2026-05-13 3:08 ` applied: " Thomas Lamprecht
2026-05-13 8:15 ` Fiona Ebner [this message]
2026-05-13 11:50 ` Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09f5cf1a-16ec-49d4-a4de-2b412f385988@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.