From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 845D11FF13A
	for <inbox@lore.proxmox.com>; Wed, 13 May 2026 10:16:25 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 5B73F29C7;
	Wed, 13 May 2026 10:16:25 +0200 (CEST)
Message-ID: <09f5cf1a-16ec-49d4-a4de-2b412f385988@proxmox.com>
Date: Wed, 13 May 2026 10:15:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH pve-network 1/1] sdn: api: route maps: fix json schema for
 match, set and exit-action
To: Stefan Hanreich <s.hanreich@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260512134336.312909-1-s.hanreich@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20260512134336.312909-1-s.hanreich@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1778660034719
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.009 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: G2VHLIL32HOG2YB36LCBJO77HQ7I3ABW
X-Message-ID-Hash: G2VHLIL32HOG2YB36LCBJO77HQ7I3ABW
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 12.05.26 um 3:41 PM schrieb Stefan Hanreich:
> The 2 keys that can have a value in the exit-action both refer to the
> order number of a route map entry, so change the type to the
> pre-defined route map order type.

---snip 8<---

> @@ -187,11 +189,7 @@ sub route_map_properties {
>                          'on-match-goto', 'on-match-next', 'continue',
>                      ],
>                  },
> -                value => {
> -                    type => 'string',
> -                    optional => 1,
> -                    description => 'type of exit action',
> -                },
> +                value => get_standard_option('pve-sdn-route-map-order'),

Don't we need an ', { optional => 1 }' here?

>              },
>              optional => 1,
>          },