From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] api: apt: list_updates: fix dependency detection for virtual package
Date: Mon, 7 Feb 2022 10:17:08 +0100 [thread overview]
Message-ID: <09e605a2-f74c-b0e0-eebb-4f824dbdfec0@proxmox.com> (raw)
In-Reply-To: <20220203113219.119833-1-f.ebner@proxmox.com>
Am 03.02.22 um 12:32 schrieb Fabian Ebner:
> A virtual package does not have SelectedState Install, but the
> dependency will still be satisfied if a package providing it has.
>
> Fixes a bug, wrongly showing that postfix will be installed, when a
> different mail-transport-agent is installed and a pve-manager update
> is available:
> https://forum.proxmox.com/threads/103413/
>
Turns out the same issue is present in PMG and PBS.. I guess the plan is
to move the rest of the APT stuff from PBS to proxmox-apt, fix it there
and re-use the proxmox-apt implementation everywhere.
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Note for testers: the API call uses a cache.
>
> PVE/API2/APT.pm | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
> index 5344f5e8..dcd87c37 100644
> --- a/PVE/API2/APT.pm
> +++ b/PVE/API2/APT.pm
> @@ -195,6 +195,13 @@ my $update_pve_pkgstatus = sub {
> for my $d (@$deps) {
> if ($d->{DepType} eq 'Depends') {
> $found = $d->{TargetPkg}->{SelectedState} eq 'Install' if !$found;
> + # need to check ProvidesList for virtual packages
> + if (!$found && (my $provides = $d->{TargetPkg}->{ProvidesList})) {
> + for my $provide ($provides->@*) {
> + $found = $provide->{OwnerPkg}->{SelectedState} eq 'Install';
> + last if $found;
> + }
> + }
> $req = $d->{TargetPkg} if !$req;
>
> if (!($d->{CompType} & AptPkg::Dep::Or)) {
prev parent reply other threads:[~2022-02-07 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 11:32 Fabian Ebner
2022-02-04 16:45 ` [pve-devel] applied: " Thomas Lamprecht
2022-02-07 9:17 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09e605a2-f74c-b0e0-eebb-4f824dbdfec0@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal