From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager v6 0/6] remote task cache fetching task / better cache backend
Date: Wed, 20 Aug 2025 10:30:29 +0200 [thread overview]
Message-ID: <09de6241-7032-426b-996d-cac807a884e3@proxmox.com> (raw)
In-Reply-To: <20250814075622.51786-1-l.wagner@proxmox.com>
looked through the patch in more detail (see the relevant patches)
most minor comments from me can be ignores since they're just
style things
but two things stood out
* after installing the packages before finishing fetching, i got an
error in the ui, probably should return an emtpy list in that case?
* the error handling for panic'ing joins (see my comment on 2/6)
of those two are solved, with or without changes for my remaining
comments, consider this series
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-08-20 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 7:56 Lukas Wagner
2025-08-14 7:56 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 1/6] remote tasks: implement improved cache for remote tasks Lukas Wagner
2025-08-19 14:24 ` Dominik Csapak
2025-08-20 7:50 ` Dominik Csapak
2025-08-14 7:56 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 2/6] remote tasks: add background task for task polling, use new task cache Lukas Wagner
2025-08-20 8:25 ` Dominik Csapak
2025-08-14 7:56 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 3/6] pdm-api-types: remote tasks: add new_from_str constructor for TaskStateType Lukas Wagner
2025-08-14 7:56 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 4/6] fake remote: make the fake_remote feature compile again Lukas Wagner
2025-08-20 8:26 ` Dominik Csapak
2025-08-20 8:27 ` Dominik Csapak
2025-08-14 7:56 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 5/6] fake remote: clippy fixes Lukas Wagner
2025-08-14 7:56 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 6/6] fixup! fake remote: make the fake_remote feature compile again Lukas Wagner
2025-08-14 7:59 ` Lukas Wagner
2025-08-20 8:30 ` Dominik Csapak [this message]
2025-08-20 12:47 ` [pdm-devel] superseded: [PATCH proxmox-datacenter-manager v6 0/6] remote task cache fetching task / better cache backend Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09de6241-7032-426b-996d-cac807a884e3@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.