all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] create lvm: improve rounding/alignment for non-pve products
@ 2022-11-28 20:41 Stoiko Ivanov
  2022-11-29  7:04 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2022-11-28 20:41 UTC (permalink / raw)
  To: pve-devel

This commit follows
1a5fa7b0936381314f613e525255078093f7f258

for PMG and PBS installations.
without it installation fails due to one missing extent when creating
the root LV.

minimally tested on a VM of mine

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 proxinstall | 1 +
 1 file changed, 1 insertion(+)

diff --git a/proxinstall b/proxinstall
index c07e6cd..396e344 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1155,6 +1155,7 @@ sub create_lvm_volumes {
     } else {
 	my $minfree = defined($config_options->{minfree}) ? $config_options->{minfree}*1024*1024 : $space;
 	$rootsize = $os_size - $minfree - $swap_size; # in KB
+	$rootsize &= ~0xFFF; # align down to 4 MB boundaries
     }
 
     if ($swap_size) {
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH installer] create lvm: improve rounding/alignment for non-pve products
  2022-11-28 20:41 [pve-devel] [PATCH installer] create lvm: improve rounding/alignment for non-pve products Stoiko Ivanov
@ 2022-11-29  7:04 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-11-29  7:04 UTC (permalink / raw)
  To: Proxmox VE development discussion, Stoiko Ivanov

Am 28/11/2022 um 21:41 schrieb Stoiko Ivanov:
> This commit follows
> 1a5fa7b0936381314f613e525255078093f7f258
> 
> for PMG and PBS installations.
> without it installation fails due to one missing extent when creating
> the root LV.
> 
> minimally tested on a VM of mine
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  proxinstall | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!

Did the same for the swap size as otherwise that could get rounded up too,
which then might lead to be short of one PE again.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-29  7:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28 20:41 [pve-devel] [PATCH installer] create lvm: improve rounding/alignment for non-pve products Stoiko Ivanov
2022-11-29  7:04 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal