* [pve-devel] [PATCH access-control] perms: fix wrong /pools entry in default set of ACL paths
@ 2023-11-08 10:29 Fabian Grünbichler
2023-11-08 12:07 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2023-11-08 10:29 UTC (permalink / raw)
To: pve-devel
/pools is not an allowed ACL path, so this would add a bogus entry into the
effective permissions in case something got propagated from /.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
stumbled upon this while working on unrelated pool stuff..
src/PVE/RPCEnvironment.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/RPCEnvironment.pm b/src/PVE/RPCEnvironment.pm
index 5eb339a..646a9b9 100644
--- a/src/PVE/RPCEnvironment.pm
+++ b/src/PVE/RPCEnvironment.pm
@@ -242,7 +242,7 @@ sub get_effective_permissions {
'/access' => 1,
'/access/groups' => 1,
'/nodes' => 1,
- '/pools' => 1,
+ '/pool' => 1,
'/sdn' => 1,
'/storage' => 1,
'/vms' => 1,
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH access-control] perms: fix wrong /pools entry in default set of ACL paths
2023-11-08 10:29 [pve-devel] [PATCH access-control] perms: fix wrong /pools entry in default set of ACL paths Fabian Grünbichler
@ 2023-11-08 12:07 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-11-08 12:07 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Grünbichler
Am 08/11/2023 um 11:29 schrieb Fabian Grünbichler:
> /pools is not an allowed ACL path, so this would add a bogus entry into the
> effective permissions in case something got propagated from /.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> stumbled upon this while working on unrelated pool stuff..
>
> src/PVE/RPCEnvironment.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-08 12:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-08 10:29 [pve-devel] [PATCH access-control] perms: fix wrong /pools entry in default set of ACL paths Fabian Grünbichler
2023-11-08 12:07 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.