[pve-devel] [PATCH] fix #5869: d/postinst: do not fail if ifreload fails on first install

[pve-devel] [PATCH] fix #5869: d/postinst: do not fail if ifreload fails on first install

[Stoiko Ivanov]

erroring out here will not help getting a running network, therefore
just log a warning.

Tested the original reporters case (running in a debootstrap) with:
```
mmdebstrap \
 --variant=minbase \
 --include=/tmp/ifupdown2_3.2.0-1+pmx10_all.deb \
 --hook-dir=/usr/share/mmdebstrap/hooks/file-mirror-automount \
 bookworm \
 ./bookworm-amd64.tar.zst
```
ran through our install on plain debian guide:
https://pve.proxmox.com/wiki/Install_Proxmox_VE_on_Debian_12_Bookworm
with this package in a local repository to check for regressions

adding the reference to the commit that introduced the reload on
first-install, as this got shifted around a bit and it took me too
long to see that we did not want to error out here on purpose

Fixes: 86335f3f898c59864a09a3e13b8146c0a0ea079d
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 debian/ifupdown2.postinst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/ifupdown2.postinst b/debian/ifupdown2.postinst
index 0137ea8..a22b825 100644
--- a/debian/ifupdown2.postinst
+++ b/debian/ifupdown2.postinst
@@ -114,7 +114,7 @@ case "$1" in
         if [ -f "/tmp/.ifupdown2-first-install" ] && [ ! -e /proxmox_install_mode ]; then
             proxmox_compatibility
             echo "Reloading network config on first install"
-            ifreload -a
+            ifreload -a || report_warn "Reloading failed"
             rm  /tmp/.ifupdown2-first-install
         fi
     ;;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH] fix #5869: d/postinst: do not fail if ifreload fails on first install

[Thomas Lamprecht]

Am 13.11.24 um 20:01 schrieb Stoiko Ivanov:
> erroring out here will not help getting a running network, therefore
> just log a warning.
> 
> Tested the original reporters case (running in a debootstrap) with:
> ```
> mmdebstrap \
>  --variant=minbase \
>  --include=/tmp/ifupdown2_3.2.0-1+pmx10_all.deb \
>  --hook-dir=/usr/share/mmdebstrap/hooks/file-mirror-automount \
>  bookworm \
>  ./bookworm-amd64.tar.zst
> ```
> ran through our install on plain debian guide:
> https://pve.proxmox.com/wiki/Install_Proxmox_VE_on_Debian_12_Bookworm
> with this package in a local repository to check for regressions
> 
> adding the reference to the commit that introduced the reload on
> first-install, as this got shifted around a bit and it took me too
> long to see that we did not want to error out here on purpose
> 
> Fixes: 86335f3f898c59864a09a3e13b8146c0a0ea079d
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  debian/ifupdown2.postinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel