all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [pbs-devel] [PATCH widget-toolkit v4 2/4] toolkit: add markdown based NotesView and NotesEdit
Date: Wed, 6 Apr 2022 13:39:23 +0200	[thread overview]
Message-ID: <091a8c77-cc99-a3ab-4d0e-4246e5e532f8@proxmox.com> (raw)
In-Reply-To: <e849acca-942e-0fd0-9cd5-2c14860890ae@proxmox.com>

On 06.04.22 10:26, Stefan Sterz wrote:
> I realized that there are some more improvements to be made here, I'll
> send an updated version in a bit. Sorry for the inconvenience.

maybe use that to keep the changes separate from the move, i.e., do a 1:1
move (as close as possible/sensible) and then do the changes/optimizations
in a separate patch.





WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH widget-toolkit v4 2/4] toolkit: add markdown based NotesView and NotesEdit
Date: Wed, 6 Apr 2022 13:39:23 +0200	[thread overview]
Message-ID: <091a8c77-cc99-a3ab-4d0e-4246e5e532f8@proxmox.com> (raw)
In-Reply-To: <e849acca-942e-0fd0-9cd5-2c14860890ae@proxmox.com>

On 06.04.22 10:26, Stefan Sterz wrote:
> I realized that there are some more improvements to be made here, I'll
> send an updated version in a bit. Sorry for the inconvenience.

maybe use that to keep the changes separate from the move, i.e., do a 1:1
move (as close as possible/sensible) and then do the changes/optimizations
in a separate patch.





  reply	other threads:[~2022-04-06 11:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01 10:19 [pve-devel] [PATCH SERIES v4 0/4] add notes to functionality to pbs webui Stefan Sterz
2022-04-01 10:19 ` [pbs-devel] " Stefan Sterz
2022-04-01 10:19 ` [pve-devel] [PATCH proxmox-backup v4 1/4] fix #3067: docs: add markdown primer from pve to pbs Stefan Sterz
2022-04-01 10:19   ` [pbs-devel] " Stefan Sterz
2022-04-01 10:19 ` [pve-devel] [PATCH widget-toolkit v4 2/4] toolkit: add markdown based NotesView and NotesEdit Stefan Sterz
2022-04-01 10:19   ` [pbs-devel] " Stefan Sterz
2022-04-06  8:26   ` [pve-devel] " Stefan Sterz
2022-04-06  8:26     ` [pbs-devel] " Stefan Sterz
2022-04-06 11:39     ` Thomas Lamprecht [this message]
2022-04-06 11:39       ` Thomas Lamprecht
2022-04-01 10:19 ` [pve-devel] [PATCH proxmox-backup v4 3/4] fix #3067: ui: add a separate notes view for longer markdown notes Stefan Sterz
2022-04-01 10:19   ` [pbs-devel] " Stefan Sterz
2022-04-01 10:19 ` [pve-devel] [PATCH manager v4 4/4] ui: move NotesView panel and NotesEdit window to widget kit Stefan Sterz
2022-04-01 10:19   ` [pbs-devel] " Stefan Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=091a8c77-cc99-a3ab-4d0e-4246e5e532f8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal