* [pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage
@ 2023-11-21 11:36 Christian Ebner
2023-11-21 11:45 ` Philipp Hufnagl
0 siblings, 1 reply; 2+ messages in thread
From: Christian Ebner @ 2023-11-21 11:36 UTC (permalink / raw)
To: pve-devel
SI units are used for storage size information, as typically used by
hard disk manufacturers.
Change the root filesystem usage values in the node summary to be
consistent.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
Will also send a patch for PMG to be consistent across all of them.
changes since v1:
- use more compact renderer invocation, same as used in PBS
www/manager6/node/StatusView.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
index d34724f7..f6cd42ad 100644
--- a/www/manager6/node/StatusView.js
+++ b/www/manager6/node/StatusView.js
@@ -72,7 +72,7 @@ Ext.define('PVE.node.StatusView', {
title: '/ ' + gettext('HD space'),
valueField: 'rootfs',
maxField: 'rootfs',
- renderer: Proxmox.Utils.render_node_size_usage,
+ renderer: ({ used, total }) => Proxmox.Utils.render_size_usage(used, total, true),
},
{
iconCls: 'fa fa-fw fa-refresh',
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage
2023-11-21 11:36 [pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage Christian Ebner
@ 2023-11-21 11:45 ` Philipp Hufnagl
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hufnagl @ 2023-11-21 11:45 UTC (permalink / raw)
To: pve-devel
On 11/21/23 12:36, Christian Ebner wrote:
> SI units are used for storage size information, as typically used by
> hard disk manufacturers.
>
> Change the root filesystem usage values in the node summary to be
> consistent.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>
> Will also send a patch for PMG to be consistent across all of them.
>
> changes since v1:
> - use more compact renderer invocation, same as used in PBS
>
> www/manager6/node/StatusView.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
> index d34724f7..f6cd42ad 100644
> --- a/www/manager6/node/StatusView.js
> +++ b/www/manager6/node/StatusView.js
> @@ -72,7 +72,7 @@ Ext.define('PVE.node.StatusView', {
> title: '/ ' + gettext('HD space'),
> valueField: 'rootfs',
> maxField: 'rootfs',
> - renderer: Proxmox.Utils.render_node_size_usage,
> + renderer: ({ used, total }) => Proxmox.Utils.render_size_usage(used, total, true),
> },
> {
> iconCls: 'fa fa-fw fa-refresh',
LGTM
Tested-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
Reviewed-by: Philipp Hufnagl <p.hufangl@proxmox.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-21 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 11:36 [pve-devel] [PATCH v2 pve-manager] ui: node summary: use SI units for HD usage Christian Ebner
2023-11-21 11:45 ` Philipp Hufnagl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal