Re: [pbs-devel] [PATCH v1 proxmox-backup 3/3] manager_bin: add --ignore-verified and --outdated-after parameters

[Dominik Csapak <d.csapak@proxmox.com>]

comment inline:

On 6/11/21 09:50, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>   src/bin/proxmox-backup-manager.rs | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/src/bin/proxmox-backup-manager.rs b/src/bin/proxmox-backup-manager.rs
> index c3806a31..e0baa20d 100644
> --- a/src/bin/proxmox-backup-manager.rs
> +++ b/src/bin/proxmox-backup-manager.rs
> @@ -269,6 +269,14 @@ async fn pull_datastore(
>               "store": {
>                   schema: DATASTORE_SCHEMA,
>               },
> +            "ignore-verified": {
> +                schema: IGNORE_VERIFIED_BACKUPS_SCHEMA,
> +                optional: true,
> +            },
> +            "outdated-after": {
> +                schema: VERIFICATION_OUTDATED_AFTER_SCHEMA,
> +                optional: true,
> +            },
>               "output-format": {
>                   schema: OUTPUT_FORMAT,
>                   optional: true,
> @@ -286,7 +294,7 @@ async fn verify(
>   
>       let mut client = connect_to_localhost()?;
>   
> -    let args = json!({});
> +    let args = json!(param);
>   

caution, this still potentially contains the 'output-format' parameter
which will not work with the api, so we have to remove it here
(or use the 'extract_output_format' instead above)

>       let path = format!("api2/json/admin/datastore/{}/verify", store);
>   
>