Re: [PATCH pve-network v5 7/7] fix #7520: config: prune orphaned and relocate moved VNet ACLs

[David Riley <d.riley@proxmox.com>]

comment inline

On 7/15/26 5:00 PM, Stefan Hanreich wrote:
> On 7/7/26 2:06 PM, David Riley wrote:
>> [snip]
>>
>> ---
>>   src/PVE/Network/SDN.pm | 115 +++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 115 insertions(+)
>>
>> diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
>> index 33a3cf3..5da425e 100644
>> --- a/src/PVE/Network/SDN.pm
>> +++ b/src/PVE/Network/SDN.pm
>> @@ -10,6 +10,7 @@ use LWP::UserAgent;
>>   use Net::SSLeay;
>>   use UUID;
>>   
>> +use PVE::AccessControl;
>>   use PVE::Cluster qw(cfs_read_file cfs_write_file cfs_lock_file);
>>   use PVE::INotify;
>>   use PVE::RESTEnvironment qw(log_warn);
>> @@ -238,11 +239,125 @@ sub compile_running_cfg {
>>   }
>>   
>>   sub commit_config {
>> +    my $old_cfg = cfs_read_file($RUNNING_CFG_FILENAME);
> nit: there is already running_config() for accessing the running_config.
> suppose we shoudl adjust it in compile_running_cfg as well while we're at it

Ah missed that. I'll adapt this in v6.
I'll also replace it in the compile_running_cfg in a separate commit to
keep the code tidy.

>
>>       my $cfg = compile_running_cfg();
>>   
>> +    cleanup_access_control($old_cfg, $cfg);
>> +
>>       cfs_write_file($RUNNING_CFG_FILENAME, $cfg);
>>   }
>>   
>> [snip]
>>   
>
>
>
>