From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 393B81FF0E9 for ; Thu, 16 Jul 2026 09:11:53 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5C9EC21418; Thu, 16 Jul 2026 09:11:52 +0200 (CEST) Message-ID: <0823c315-bf27-4c39-a4bd-9fbd0eca6742@proxmox.com> Date: Thu, 16 Jul 2026 09:11:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network v5 7/7] fix #7520: config: prune orphaned and relocate moved VNet ACLs To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260707120404.73072-1-d.riley@proxmox.com> <20260707120404.73072-8-d.riley@proxmox.com> <9722561d-b631-402e-b69b-dde095bb206e@proxmox.com> Content-Language: en-US From: David Riley In-Reply-To: <9722561d-b631-402e-b69b-dde095bb206e@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784185886137 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.208 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BJXGGTFTVS4T7KZNQTN5PHSI5R4LEOO3 X-Message-ID-Hash: BJXGGTFTVS4T7KZNQTN5PHSI5R4LEOO3 X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: comment inline On 7/15/26 5:00 PM, Stefan Hanreich wrote: > On 7/7/26 2:06 PM, David Riley wrote: >> [snip] >> >> --- >> src/PVE/Network/SDN.pm | 115 +++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 115 insertions(+) >> >> diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm >> index 33a3cf3..5da425e 100644 >> --- a/src/PVE/Network/SDN.pm >> +++ b/src/PVE/Network/SDN.pm >> @@ -10,6 +10,7 @@ use LWP::UserAgent; >> use Net::SSLeay; >> use UUID; >> >> +use PVE::AccessControl; >> use PVE::Cluster qw(cfs_read_file cfs_write_file cfs_lock_file); >> use PVE::INotify; >> use PVE::RESTEnvironment qw(log_warn); >> @@ -238,11 +239,125 @@ sub compile_running_cfg { >> } >> >> sub commit_config { >> + my $old_cfg = cfs_read_file($RUNNING_CFG_FILENAME); > nit: there is already running_config() for accessing the running_config. > suppose we shoudl adjust it in compile_running_cfg as well while we're at it Ah missed that. I'll adapt this in v6. I'll also replace it in the compile_running_cfg in a separate commit to keep the code tidy. > >> my $cfg = compile_running_cfg(); >> >> + cleanup_access_control($old_cfg, $cfg); >> + >> cfs_write_file($RUNNING_CFG_FILENAME, $cfg); >> } >> >> [snip] >> > > > >