From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: fix opening settings window in datastore panel
Date: Wed, 15 Dec 2021 15:57:16 +0100 [thread overview]
Message-ID: <07922b58-e576-9758-c182-5f2ad35311b1@proxmox.com> (raw)
In-Reply-To: <20211202142631.1200891-1-d.csapak@proxmox.com>
On 02.12.21 15:26, Dominik Csapak wrote:
> When a user directly opened the webui with a fragment that is not
> the summary, opening of the 'my settings' window fails because the
> initial set of the columns field triggers a state change, which in turn
> tries to trigger 'updateColumns'. That fails though, since the columns
> were not even rendered yet (because we are on a different tab).
>
> To fix this, simply return when the panel is not rendered yet.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/datastore/Summary.js | 3 +++
> 1 file changed, 3 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2021-12-15 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 14:26 [pbs-devel] " Dominik Csapak
2021-12-15 14:57 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07922b58-e576-9758-c182-5f2ad35311b1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.